You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/06 19:10:00 UTC
[jira] [Commented] (NIFI-4673)
TestListenAndPutSyslog.testTLSListenerNoTLSPut test is brittle and breaks
the build
[ https://issues.apache.org/jira/browse/NIFI-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280699#comment-16280699 ]
ASF GitHub Bot commented on NIFI-4673:
--------------------------------------
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/2325
NIFI-4673 changed it to an integration test and reduced travis-ci thr…
…ead count
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-4673
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2325.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2325
----
commit c53243b4b2e8a9894e5b1359a76e2406021880bf
Author: joewitt <jo...@apache.org>
Date: 2017-12-06T17:03:16Z
NIFI-4673 changed it to an integration test and reduced travis-ci thread count
----
> TestListenAndPutSyslog.testTLSListenerNoTLSPut test is brittle and breaks the build
> -----------------------------------------------------------------------------------
>
> Key: NIFI-4673
> URL: https://issues.apache.org/jira/browse/NIFI-4673
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Joseph Witt
> Assignee: Joseph Witt
> Fix For: 1.5.0
>
>
> {noformat}
> Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.369 sec <<< FAILURE! - in org.apache.nifi.processors.standard.TestListenAndPutSyslog
> testTLSListenerNoTLSPut(org.apache.nifi.processors.standard.TestListenAndPutSyslog) Time elapsed: 0.029 sec <<< FAILURE!
> java.lang.AssertionError: java.lang.NullPointerException
> at org.apache.nifi.processors.standard.TestListenAndPutSyslog.run(TestListenAndPutSyslog.java:155)
> at org.apache.nifi.processors.standard.TestListenAndPutSyslog.testTLSListenerNoTLSPut(TestListenAndPutSyslog.java:101)
> Caused by: java.lang.NullPointerException
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)