You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/23 18:06:33 UTC

[GitHub] [spark] tgravescs commented on a change in pull request #25037: [SPARK-27489][WEBUI] UI updates to show executor resource information

tgravescs commented on a change in pull request #25037: [SPARK-27489][WEBUI] UI updates to show executor resource information
URL: https://github.com/apache/spark/pull/25037#discussion_r306458317
 
 

 ##########
 File path: core/src/main/resources/org/apache/spark/ui/static/executorspage.js
 ##########
 @@ -39,6 +39,19 @@ function formatStatus(status, type, row) {
     return "Dead"
 }
 
+function formatResourceCells(resources) {
 
 Review comment:
   I was trying to take up less space. the linked PR adds in checkboxes to show columns so we could break up more if its not on by default, but I think at this point we should start with something small and then enhance later as people figure out what is useful. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org