[GitHub] [hbase] Apache9 commented on a change in pull request #974: HBASE-23587 The FSYNC_WAL flag does not work on branch-2.x

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #974: HBASE-23587 The FSYNC_WAL flag does not work on branch-2.x
URL: https://github.com/apache/hbase/pull/974#discussion_r362321150
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
 ##########
 @@ -577,10 +577,9 @@ public void run() {
           //TraceScope scope = Trace.continueSpan(takeSyncFuture.getSpan());
           long start = System.nanoTime();
           Throwable lastException = null;
-          boolean wasRollRequested = false;
           try {
             TraceUtil.addTimelineAnnotation("syncing writer");
-            writer.sync(useHsync);
+            writer.sync(takeSyncFuture.isForceSync());
 
 Review comment:
   This was also confusing me a bit but after investigating, I think the logic is correct. As this config can be changed at table level or even mutation level by design, we should follow what we have in the SyncFuture, as it is set when syncing the WAL in HRegion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services