You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by mikewallace1979 <gi...@git.apache.org> on 2015/06/03 16:16:33 UTC
[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork
GitHub user mikewallace1979 opened a pull request:
https://github.com/apache/couchdb-fabric/pull/20
Merge diff from cloudant fork
This PR brings in three commits made directly to the cloudant fork of fabric after the last significant chunk of merge work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb-fabric merge-diff-from-cloudant-fork
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fabric/pull/20.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20
----
commit d7d6be8535443fd3ddbe65c0a6a35534b4b98e29
Author: Eric Avdey <ei...@eiri.ca>
Date: 2014-11-11T00:12:42Z
Provide an access to a document info
The functions `get_doc_info/3` and `get_full_doc_info/3` were
added to API to provide an access to the records `#doc_info{}`
and `#full_doc_info{}` accordingly.
The functions are re-using `fabric_open_doc` coordinator
and consequently are the subject of the same read quorum rules
as `open_doc/3` function. However the info functions do not trigger
read repair on a not fully complete quorum.
Function `get_full_doc_info/3` accepts an option `deleted` to
allow to provide an information for a deleted document,
similar to `open_doc/3`.
FogBugz: 12933
This is a cherry-pick of:
https://github.com/cloudant/fabric/commit/c85569287ad8f86122b47775adc2ab9218db0322
Conflicts:
src/fabric_rpc.erl
commit 383f8f4dc46737fac646a6d90ff03b64c0d94109
Author: Robert Newson <rn...@apache.org>
Date: 2015-03-29T12:38:38Z
Add ability to gracefully terminate existing changes feeds
Calling fabric:end_changes() will cause all current changes
feeds to gracefully exit without preventing new changes requests from
starting (unlike maintenance_mode).
BugzID: 45762
This is a cherry-pick of:
https://github.com/cloudant/fabric/commit/1b45cede8f11e209f28e3d06b9fda4cbdcd719cc
Conflicts:
src/fabric.erl
src/fabric_view_changes.erl
commit ece2b2ed9114d454eea79d8788f8d0c01f172ed9
Author: Robert Newson <rn...@apache.org>
Date: 2015-04-09T22:07:19Z
export dbname/1
BugzID: 45853
This is a cherry-pick of:
https://github.com/cloudant/fabric/commit/818dd09e9ea645e866fc62fd1a4302ce73b2422a
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/20#discussion_r31825932
--- Diff: src/fabric_doc_open.erl ---
@@ -30,7 +30,12 @@
go(DbName, Id, Options) ->
- Workers = fabric_util:submit_jobs(mem3:shards(DbName,Id), open_doc,
+ Handler = case proplists:get_value(doc_info, Options) of
--- End diff --
Good call!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/20#issuecomment-108923480
+1 after proplist fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork
Posted by mikewallace1979 <gi...@git.apache.org>.
Github user mikewallace1979 commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/20#discussion_r31825883
--- Diff: src/fabric_doc_open.erl ---
@@ -30,7 +30,12 @@
go(DbName, Id, Options) ->
- Workers = fabric_util:submit_jobs(mem3:shards(DbName,Id), open_doc,
+ Handler = case proplists:get_value(doc_info, Options) of
--- End diff --
There were only two calls to proplists:get_value outside of this PR so I put them in a separate commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork
Posted by mikewallace1979 <gi...@git.apache.org>.
Github user mikewallace1979 commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/20#discussion_r31825317
--- Diff: src/fabric_doc_open.erl ---
@@ -30,7 +30,12 @@
go(DbName, Id, Options) ->
- Workers = fabric_util:submit_jobs(mem3:shards(DbName,Id), open_doc,
+ Handler = case proplists:get_value(doc_info, Options) of
--- End diff --
I could make it a non-squash commit and do all the `proplists:get_value/2` calls in the module?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/20#discussion_r31825108
--- Diff: src/fabric_doc_open.erl ---
@@ -30,7 +30,12 @@
go(DbName, Id, Options) ->
- Workers = fabric_util:submit_jobs(mem3:shards(DbName,Id), open_doc,
+ Handler = case proplists:get_value(doc_info, Options) of
--- End diff --
Here is one more `proplists:get_value`...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fabric/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/20#discussion_r31626817
--- Diff: src/fabric.erl ---
@@ -161,7 +162,12 @@ get_all_security(DbName, Options) ->
{error, any()} |
{error, any() | any()}.
open_doc(DbName, Id, Options) ->
- fabric_doc_open:go(dbname(DbName), docid(Id), opts(Options)).
+ case proplists:get_value(doc_info, Options) of
--- End diff --
`couch_utl:get_value/2` is better as it based on BIF while proplists version is not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---