You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/01/19 15:46:15 UTC

Review Request 55720: AMBARI-19615 clearer error messages for stack_select.py when a role doesn't have a select component name

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55720/
-----------------------------------------------------------

Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-19615
    https://issues.apache.org/jira/browse/AMBARI-19615


Repository: ambari


Description
-------

clearer error messages for stack_select.py when a role doesn't have a select component name


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 4f6ccd2 

Diff: https://reviews.apache.org/r/55720/diff/


Testing
-------

existing unit test
patch trunk code build ambari rpms and install a trunk cluster


Thanks,

Di Li


Re: Review Request 55720: AMBARI-19615 clearer error messages for stack_select.py when a role doesn't have a select component name

Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55720/#review162298
-----------------------------------------------------------


Ship it!




Ship It!

- Tim Thorpe


On Jan. 19, 2017, 3:46 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55720/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 3:46 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19615
>     https://issues.apache.org/jira/browse/AMBARI-19615
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> clearer error messages for stack_select.py when a role doesn't have a select component name
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 4f6ccd2 
> 
> Diff: https://reviews.apache.org/r/55720/diff/
> 
> 
> Testing
> -------
> 
> existing unit test
> patch trunk code build ambari rpms and install a trunk cluster
> 
> 
> Thanks,
> 
> Di Li
> 
>