You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/13 10:42:07 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1946: Refactor Architecture Basic modification #1658
codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585172652
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/fb5de1784e22072d0597e51d6c7de5a6c126bfbf?src=pr&el=desc) will **increase** coverage by `0.45%`.
> The diff coverage is `44.82%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1946 +/- ##
============================================
+ Coverage 28.57% 29.02% +0.45%
- Complexity 1295 1314 +19
============================================
Files 294 294
Lines 14985 14979 -6
Branches 1808 1807 -1
============================================
+ Hits 4282 4348 +66
+ Misses 10272 10198 -74
- Partials 431 433 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...hinscheduler/dao/datasource/ConnectionFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ29ubmVjdGlvbkZhY3RvcnkuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dolphinscheduler/server/worker/WorkerServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9Xb3JrZXJTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `40.1% <0%> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [...apache/dolphinscheduler/alert/utils/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9Db25zdGFudHMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/dolphinscheduler/api/utils/CheckUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL0NoZWNrVXRpbHMuamF2YQ==) | `61.53% <0%> (+9.53%)` | `19 <0> (+3)` | :arrow_up: |
| [...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh) | `79.66% <0%> (ø)` | `67 <0> (ø)` | :arrow_down: |
| [...r/common/task/subprocess/SubProcessParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3VicHJvY2Vzcy9TdWJQcm9jZXNzUGFyYW1ldGVycy5qYXZh) | `16.66% <0%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...che/dolphinscheduler/common/utils/CommonUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0NvbW1vblV0aWxzLmphdmE=) | `40% <0%> (+40%)` | `5 <0> (+5)` | :arrow_up: |
| [...scheduler/dao/datasource/ClickHouseDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ2xpY2tIb3VzZURhdGFTb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dolphinscheduler/server/master/MasterServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=footer). Last update [fb5de17...ad00268](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services