[jira] [Comment Edited] (KAFKA-6786) Remove additional configs in StreamsBrokerDownResilienceTest

["Abhishek Sharma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464954#comment-16464954 ] 

Abhishek Sharma edited comment on KAFKA-6786 at 5/6/18 12:32 AM:
-----------------------------------------------------------------

Had a couple of questions:
 # Is there any sort of property file that we are expecting to use for this test? I don't see any that immediately jump out at me in the resources folder.
 # To be clear, are we planning on removing `additionalConfigs` (line 56 of StreamsBrokerDownResilienceTest)?


was (Author: abhi_sh):
Had a couple of questions:
 # Is there any sort of property file that we are expecting to use for this test? I don't see any that immediately jump out at me in the resources folder.
 # To be clear, are we planning on removing `additionalConfigs` (line 56)?

> Remove additional configs in StreamsBrokerDownResilienceTest
> ------------------------------------------------------------
>
>                 Key: KAFKA-6786
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6786
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Guozhang Wang
>            Assignee: Abhishek Sharma
>            Priority: Minor
>              Labels: newbie
>
> Since we are now passing in a property file into the streams service initialization code, we do not need to pass in those configs as additional properties in StreamsBrokerDownResilienceTest. We can refactor this test to get rid of the additional properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)