You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2007/07/09 21:07:11 UTC

DO NOT REPLY [Bug 42843] New: - [PATCH] Warn on Glyph substitution

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42843>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42843

           Summary: [PATCH] Warn on Glyph substitution
           Product: Fop
           Version: 1.0dev
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: fonts
        AssignedTo: fop-dev@xmlgraphics.apache.org
        ReportedBy: max@berger.name


Since Andreas is looking for small patches for 0.94, here is another one I've wanted for quite a while:

This patch emits warnings when a glyph is not available in a font and is replaced with a #. The 
replacement is a very annoying - yet a necessary feature of fop. However, the user should at least be 
informed about it.

I used log.warn, but log.info may also make sense here.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 42843] - [PATCH] Warn on Glyph substitution

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42843>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42843


a_l.delmelle@pandora.be changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Additional Comments From a_l.delmelle@pandora.be  2007-07-10 09:44 -------

This one also seems like a good idea. Would you (or anyone) agree to have this warning shown only the 
first time a character is not present in a particular font? (so as to not flood the log with warning messages 
all telling the very same thing...)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 42843] - [PATCH] Warn on Glyph substitution

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42843>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42843


a_l.delmelle@pandora.be changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From a_l.delmelle@pandora.be  2007-07-14 01:18 -------

OK, since no objections were raised, patch applied as-is for now.

see: http://svn.apache.org/viewvc?view=rev&rev=556239

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 42843] - [PATCH] Warn on Glyph substitution

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42843>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42843





------- Additional Comments From max@berger.name  2007-07-10 11:03 -------
just the first time would be fine with me as well, as long as their is some warning at all.

However: Just the first time means that fop would have to keep track of the warnings it emitted, which requires additional overhead, and more work. IMO reducing the number of warnings is not worth it, as the user will have to fix this for every character which gets substituted. An even better warning would also tell the user where (line / column) the character is.

However, both of these would make the patch (and associated work) much larger, which was not my intent: I just wanted a small fix that could make it into 0.94, but I am not at all against a better solution.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 42843] - [PATCH] Warn on Glyph substitution

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42843>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42843





------- Additional Comments From max@berger.name  2007-07-09 12:07 -------
Created an attachment (id=20481)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20481&action=view)
glyph warn patch


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.