[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4228: HDFS-16468. Define ssize_t for Windows

[GitBox <gi...@apache.org>]

GauthamBanasandra commented on code in PR #4228:
URL: https://github.com/apache/hadoop/pull/4228#discussion_r857913849


##########
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/jni_helper.c:
##########
@@ -487,10 +488,10 @@ static ssize_t wildcard_expandPath(const char* path, char* expanded)
  * allocated after using this function with expandedClasspath=NULL to get the
  * right size.
  */
-static ssize_t getClassPath_helper(const char *classpath, char* expandedClasspath)
+static x_platform_ssize_t getClassPath_helper(const char *classpath, char* expandedClasspath)
 {
-    ssize_t length;
-    ssize_t retval;
+    x_platform_ssize_t length;

Review Comment:
   I put the `x_platform_` prefix to avoid any possible future conflicts with ssize_t. Like, if someone were to include a third-party library header that defines its own version of ssize_t, it shouldn't affect these parts.
   That's just my view. However, I don't mind just using the ssize_t typedef instead of x_platform_ssize_t if you prefer that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org