You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/07 23:41:36 UTC
[GitHub] [druid] vogievetsky opened a new pull request #9334: Web console:
Column counter
vogievetsky opened a new pull request #9334: Web console: Column counter
URL: https://github.com/apache/druid/pull/9334
Have you ever wondered how many columns there are?
Did you never learn to count above 10 and there you are sitting in your fancy tech job and at this point it is too late to admit this to your peers?
I got you covered:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on issue #9334: Web console: Column
counter
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on issue #9334: Web console: Column counter
URL: https://github.com/apache/druid/pull/9334#issuecomment-592151761
Thanks for the 👍 Chi!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky merged pull request #9334: Web console: Column
counter
Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #9334: Web console: Column counter
URL: https://github.com/apache/druid/pull/9334
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ccaominh commented on a change in pull request #9334: Web
console: Column counter
Posted by GitBox <gi...@apache.org>.
ccaominh commented on a change in pull request #9334: Web console: Column counter
URL: https://github.com/apache/druid/pull/9334#discussion_r376738307
##########
File path: web-console/src/components/table-column-selector/__snapshots__/table-column-selector.spec.tsx.snap
##########
@@ -14,7 +14,12 @@ exports[`table column matches snapshot 1`] = `
<span
class="bp3-button-text"
>
- Columns
+ Columns
+ <span
+ class="counter"
+ >
+ (0/3)
Review comment:
May be worth it for the test to validate a scenario where some of the columns are shown
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org