You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Paulo Motta (JIRA)" <ji...@apache.org> on 2017/04/04 23:16:41 UTC
[jira] [Commented] (CASSANDRA-13224) testall failure in
org.apache.cassandra.db.compaction.CompactionStrategyManagerPendingRepairTest.cleanupCompactionFinalized
[ https://issues.apache.org/jira/browse/CASSANDRA-13224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956039#comment-15956039 ]
Paulo Motta commented on CASSANDRA-13224:
-----------------------------------------
It seems that the flaky tests [PendingRepairManagerTest|http://cassci.datastax.com/view/trunk/job/trunk_testall/lastCompletedBuild/testReport/org.apache.cassandra.db.compaction/PendingRepairManagerTest/history/] (CASSANDRA-13207, CASSANDRA-13248) and [CompactionStrategyManagerPendingRepairTest|http://cassci.datastax.com/view/trunk/job/trunk_testall/lastCompletedBuild/testReport/org.apache.cassandra.db.compaction/CompactionStrategyManagerPendingRepairTest/history/] (this and CASSANDRA-13206) have all a common root cause:
{noformat}
DEBUG [CompactionExecutor:4] 2017-02-20 15:10:45,045 Removing compaction strategy for pending repair c0921d40-f77e-11e6-9d70-e9c36734696d on ks_1487603444905.tbl
{noformat}
Which seems to be caused by a race with auto-compactions triggered by flush, so the simple fix is to just disable autocompaction during these tests. I managed to reproduce this with [this multiplexer run|https://cassci.datastax.com/job/pauloricardomg-testall-multiplex/4/] and fixed by disabling autocompaction during tests: [fixed multiplexer run|https://cassci.datastax.com/job/pauloricardomg-testall-multiplex/5/]
Besides this, I also aborted transactions created by {{PendingRepairManager.getNextBackgroundTask}} after the assertions since they are causing {{LEAK DETECTED}} errors.
I am assuming (and hoping) you haven't started working on this yet so if you haven't done so would you mind reviewing this [~bdeggleston]? Otherwise I'm happy to review your patch if you already have one in place. Thanks!
||trunk||
|[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-13224]|
|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-13224-testall/lastCompletedBuild/testReport/]|
> testall failure in org.apache.cassandra.db.compaction.CompactionStrategyManagerPendingRepairTest.cleanupCompactionFinalized
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-13224
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13224
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
> Reporter: Sean McCarthy
> Assignee: Blake Eggleston
> Labels: test-failure, testall
> Attachments: TEST-org.apache.cassandra.db.compaction.CompactionStrategyManagerPendingRepairTest.log
>
>
> example failure:
> http://cassci.datastax.com/job/trunk_testall/1407/testReport/org.apache.cassandra.db.compaction/CompactionStrategyManagerPendingRepairTest/cleanupCompactionFinalized
> {code}
> Stacktrace
> junit.framework.AssertionFailedError:
> at org.apache.cassandra.db.compaction.CompactionStrategyManagerPendingRepairTest.cleanupCompactionFinalized(CompactionStrategyManagerPendingRepairTest.java:235)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)