You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/14 22:59:41 UTC

[jira] [Commented] (BEAM-1709) Implement Single-output ParDo as Multi-output ParDo

    [ https://issues.apache.org/jira/browse/BEAM-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925206#comment-15925206 ] 

ASF GitHub Bot commented on BEAM-1709:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2248

    [BEAM-1709] Implement Single-Output ParDo as a composite

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    This rolls-forwards after commit 8766b03.
    
    Reset back to spark translations, and re-merge
    
    Implement a Primitive ParDoSingle override in the Dataflow Runner.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam no_par_do_single

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2248
    
----
commit 9e8e5c9b3b7d449485f2f0f0c69e82e18337b5a5
Author: Thomas Groh <tg...@google.com>
Date:   2017-03-14T19:39:57Z

    Migrate ForwardingPTransform to core-construction

commit 0145825e38f11f6730bf5d0c02aca1b9b9370c28
Author: Thomas Groh <tg...@google.com>
Date:   2017-03-14T18:02:15Z

    Implement Single-Output ParDo as a composite
    
    This rolls-forwards after commit 8766b03eb31b4f16de8fbf5a6902378a2c1151e0.
    
    Reset back to spark translations, and re-merge
    
    Implement a Primitive ParDoSingle override in the Dataflow Runner.

----


> Implement Single-output ParDo as Multi-output ParDo
> ---------------------------------------------------
>
>                 Key: BEAM-1709
>                 URL: https://issues.apache.org/jira/browse/BEAM-1709
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>            Priority: Minor
>              Labels: starter
>             Fix For: First stable release
>
>
> Runners who want a primitive Single-output ParDo should implement an override to do so.
> Initially implemented in https://github.com/apache/beam/pull/2145, rolled back in https://github.com/apache/beam/pull/2170



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)