You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/05/19 11:48:49 UTC
[GitHub] [spark] panbingkun opened a new pull request, #41236: [SPARK-43591][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_0013
panbingkun opened a new pull request, #41236:
URL: https://github.com/apache/spark/pull/41236
### What changes were proposed in this pull request?
The pr aims to assign a name to the error class _LEGACY_ERROR_TEMP_0013.
### Why are the changes needed?
The changes improve the error framework.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #41236: [SPARK-43591][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_0013
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #41236:
URL: https://github.com/apache/spark/pull/41236#issuecomment-1557969773
+1, LGTM. Merging to master.
Thank you, @panbingkun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #41236: [SPARK-43591][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_0013
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #41236:
URL: https://github.com/apache/spark/pull/41236#discussion_r1200048746
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1877,6 +1877,11 @@
"JOIN USING with LATERAL correlation."
]
},
+ "LATERAL_WITH_PIVOT" : {
Review Comment:
The main point is the combination is not allowed in `FROM`. Since there are 3 related errors:
- unpivotWithPivotInFromClauseNotAllowedError
- lateralWithPivotInFromClauseNotAllowedError
- lateralWithUnpivotInFromClauseNotAllowedError
Could you add the error class `NOT_ALLOWED_IN_FROM`, and add sub-classes to it, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #41236: [SPARK-43591][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_0013
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41236:
URL: https://github.com/apache/spark/pull/41236#discussion_r1200088938
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1877,6 +1877,11 @@
"JOIN USING with LATERAL correlation."
]
},
+ "LATERAL_WITH_PIVOT" : {
Review Comment:
Ok, Let me do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #41236: [SPARK-43591][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_0013
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #41236:
URL: https://github.com/apache/spark/pull/41236#discussion_r1199700657
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -5627,4 +5627,4 @@
"Failed to get block <blockId>, which is not a shuffle block"
]
}
-}
+}
Review Comment:
Unnecessary change. Please, revert it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #41236: [SPARK-43591][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_0013
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #41236:
URL: https://github.com/apache/spark/pull/41236#discussion_r1200242564
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1282,6 +1282,28 @@
"Operation <operation> is not allowed for <tableIdentWithDB> because it is not a partitioned table."
]
},
+ "NOT_ALLOWED_IN_FROM" : {
+ "message" : [
+ "Not supported in the From clause:"
Review Comment:
```suggestion
"Not allowed in the FROM clause:"
```
and sub-classes like:
```
"LATERAL_WITH_PIVOT" : {
"message" : [
"LATERAL together with PIVOT."
]
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #41236: [SPARK-43591][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_0013
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41236:
URL: https://github.com/apache/spark/pull/41236#discussion_r1200399807
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -5627,4 +5627,4 @@
"Failed to get block <blockId>, which is not a shuffle block"
]
}
-}
+}
Review Comment:
I have proposed a new PR to address this issue
PR: https://github.com/apache/spark/pull/41256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #41236: [SPARK-43591][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_0013
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41236:
URL: https://github.com/apache/spark/pull/41236#discussion_r1199739194
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -5627,4 +5627,4 @@
"Failed to get block <blockId>, which is not a shuffle block"
]
}
-}
+}
Review Comment:
This is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #41236: [SPARK-43591][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_0013
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #41236: [SPARK-43591][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_0013
URL: https://github.com/apache/spark/pull/41236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #41236: [SPARK-43591][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_0013
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41236:
URL: https://github.com/apache/spark/pull/41236#discussion_r1200149426
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1877,6 +1877,11 @@
"JOIN USING with LATERAL correlation."
]
},
+ "LATERAL_WITH_PIVOT" : {
Review Comment:
This is done.
At the same time, I also added test UT for `NOT_ALLOWED_IN_FROM.LATERAL_WITH_UNPIVOT` and `NOT_ALLOWED_IN_FROM.UNPIVOT_WITH_PIVOT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #41236: [SPARK-43591][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_0013
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41236:
URL: https://github.com/apache/spark/pull/41236#discussion_r1200353158
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1282,6 +1282,28 @@
"Operation <operation> is not allowed for <tableIdentWithDB> because it is not a partitioned table."
]
},
+ "NOT_ALLOWED_IN_FROM" : {
+ "message" : [
+ "Not supported in the From clause:"
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org