[GitHub] [incubator-superset] zuzana-vej commented on a change in pull request #9952: feat: [filter_box] disable instant_filtering by defult

[GitBox <gi...@apache.org>]

zuzana-vej commented on a change in pull request #9952:
URL: https://github.com/apache/incubator-superset/pull/9952#discussion_r432667926



##########
File path: superset-frontend/src/explore/controlPanels/FilterBox.jsx
##########
@@ -55,10 +55,10 @@ export default {
               type: 'CheckboxControl',
               label: t('Instant Filtering'),
               renderTrigger: true,
-              default: true,
-              description:
-                'Whether to apply filters as they change, or wait for ' +
-                'users to hit an [Apply] button',
+              default: false,
+              description: t(
+                'Whether to apply filters as they change, or wait for users to hit an [Apply] button',

Review comment:
       I checked what other descriptions look like (for consistency...). How about _Check to apply filters instantly as they change instead of displaying [Apply] button._




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org