You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/08 01:29:57 UTC

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1451: test: make create route with upstream test cases stable

liuxiran commented on a change in pull request #1451:
URL: https://github.com/apache/apisix-dashboard/pull/1451#discussion_r571735970



##########
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##########
@@ -46,32 +47,27 @@ context('Create Route with Upstream', () => {
     cy.contains('Submit').click();
   });
 
-  it('should enter the Route creator', function () {
+  it('should create route with upstream just created', function () {

Review comment:
       > put those into smaller test cases because they are clearer, as for login, could we try to put Line33~Line35 under beforeAll?
   
   Let me have a try~
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org