You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by al...@apache.org on 2018/11/08 18:20:49 UTC
[camel] branch master updated: Fixed some CS issues,
deprecated links and eclipse warnings in camel-http4
This is an automated email from the ASF dual-hosted git repository.
aldettinger pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/master by this push:
new e28fe1d Fixed some CS issues, deprecated links and eclipse warnings in camel-http4
e28fe1d is described below
commit e28fe1d97afdc9467bfaea1bbc6ab270ef830194
Author: aldettinger <al...@gmail.com>
AuthorDate: Thu Nov 8 19:13:23 2018 +0100
Fixed some CS issues, deprecated links and eclipse warnings in camel-http4
---
.../camel/component/http4/HttpComponent.java | 4 +-
.../apache/camel/component/http4/HttpEndpoint.java | 33 +++++-----
.../http4/CamelComponentVerifierExtensionTest.java | 5 +-
.../http4/CamelComponentVerifierTest.java | 70 +++++++++++-----------
.../component/http4/HttpsAuthenticationTest.java | 4 +-
.../apache/camel/component/http4/HttpsGetTest.java | 4 +-
...psTwoComponentsSslContextParametersGetTest.java | 4 +-
...tpsTwoDifferentSslContextParametersGetTest.java | 4 +-
.../http4/rest/RestCamelComponentVerifierTest.java | 30 +++++-----
9 files changed, 79 insertions(+), 79 deletions(-)
diff --git a/components/camel-http4/src/main/java/org/apache/camel/component/http4/HttpComponent.java b/components/camel-http4/src/main/java/org/apache/camel/component/http4/HttpComponent.java
index 5e4b004..5f5de2c 100644
--- a/components/camel-http4/src/main/java/org/apache/camel/component/http4/HttpComponent.java
+++ b/components/camel-http4/src/main/java/org/apache/camel/component/http4/HttpComponent.java
@@ -311,9 +311,9 @@ public class HttpComponent extends HttpCommonComponent implements RestProducerFa
} else {
setEndpointHeaderFilterStrategy(endpoint);
}
- endpoint.setBinding(getHttpBinding());
+ endpoint.setHttpBinding(getHttpBinding());
if (httpBinding != null) {
- endpoint.setBinding(httpBinding);
+ endpoint.setHttpBinding(httpBinding);
}
if (httpMethodRestrict != null) {
endpoint.setHttpMethodRestrict(httpMethodRestrict);
diff --git a/components/camel-http4/src/main/java/org/apache/camel/component/http4/HttpEndpoint.java b/components/camel-http4/src/main/java/org/apache/camel/component/http4/HttpEndpoint.java
index 40d3ede..6049ee3 100644
--- a/components/camel-http4/src/main/java/org/apache/camel/component/http4/HttpEndpoint.java
+++ b/components/camel-http4/src/main/java/org/apache/camel/component/http4/HttpEndpoint.java
@@ -61,6 +61,11 @@ public class HttpEndpoint extends HttpCommonEndpoint {
private static final Logger LOG = LoggerFactory.getLogger(HttpEndpoint.class);
+ @UriParam(label = "security", description = "To configure security using SSLContextParameters."
+ + " Important: Only one instance of org.apache.camel.util.jsse.SSLContextParameters is supported per HttpComponent."
+ + " If you need to use 2 or more different instances, you need to define a new HttpComponent per instance you need.")
+ protected SSLContextParameters sslContextParameters;
+
@UriParam(label = "advanced", description = "To use a custom HttpContext instance")
private HttpContext httpContext;
@UriParam(label = "advanced", description = "Register a custom configuration strategy for new HttpClient instances"
@@ -114,10 +119,6 @@ public class HttpEndpoint extends HttpCommonEndpoint {
private int connectionsPerRoute;
@UriParam(label = "security", description = "To use a custom X509HostnameVerifier such as DefaultHostnameVerifier or NoopHostnameVerifier")
private HostnameVerifier x509HostnameVerifier;
- @UriParam(label = "security", description = "To configure security using SSLContextParameters."
- + " Important: Only one instance of org.apache.camel.util.jsse.SSLContextParameters is supported per HttpComponent."
- + " If you need to use 2 or more different instances, you need to define a new HttpComponent per instance you need.")
- protected SSLContextParameters sslContextParameters;
public HttpEndpoint() {
}
@@ -191,10 +192,10 @@ public class HttpEndpoint extends HttpCommonEndpoint {
if (!useSystemProperties) {
// configure http proxy from camelContext
- if (ObjectHelper.isNotEmpty(getCamelContext().getProperty("http.proxyHost")) && ObjectHelper.isNotEmpty(getCamelContext().getProperty("http.proxyPort"))) {
- String host = getCamelContext().getProperty("http.proxyHost");
- int port = Integer.parseInt(getCamelContext().getProperty("http.proxyPort"));
- String scheme = getCamelContext().getProperty("http.proxyScheme");
+ if (ObjectHelper.isNotEmpty(getCamelContext().getGlobalOption("http.proxyHost")) && ObjectHelper.isNotEmpty(getCamelContext().getGlobalOption("http.proxyPort"))) {
+ String host = getCamelContext().getGlobalOption("http.proxyHost");
+ int port = Integer.parseInt(getCamelContext().getGlobalOption("http.proxyPort"));
+ String scheme = getCamelContext().getGlobalOption("http.proxyScheme");
// fallback and use either http or https depending on secure
if (scheme == null) {
scheme = HttpHelper.isSecureConnection(getEndpointUri()) ? "https" : "http";
@@ -480,9 +481,9 @@ public class HttpEndpoint extends HttpCommonEndpoint {
@ManagedAttribute(description = "Maximum number of allowed persistent connections")
public int getClientConnectionsPoolStatsMax() {
- ConnPoolControl pool = null;
+ ConnPoolControl<?> pool = null;
if (clientConnectionManager instanceof ConnPoolControl) {
- pool = (ConnPoolControl) clientConnectionManager;
+ pool = (ConnPoolControl<?>) clientConnectionManager;
}
if (pool != null) {
PoolStats stats = pool.getTotalStats();
@@ -495,9 +496,9 @@ public class HttpEndpoint extends HttpCommonEndpoint {
@ManagedAttribute(description = "Number of available idle persistent connections")
public int getClientConnectionsPoolStatsAvailable() {
- ConnPoolControl pool = null;
+ ConnPoolControl<?> pool = null;
if (clientConnectionManager instanceof ConnPoolControl) {
- pool = (ConnPoolControl) clientConnectionManager;
+ pool = (ConnPoolControl<?>) clientConnectionManager;
}
if (pool != null) {
PoolStats stats = pool.getTotalStats();
@@ -510,9 +511,9 @@ public class HttpEndpoint extends HttpCommonEndpoint {
@ManagedAttribute(description = "Number of persistent connections tracked by the connection manager currently being used to execute requests")
public int getClientConnectionsPoolStatsLeased() {
- ConnPoolControl pool = null;
+ ConnPoolControl<?> pool = null;
if (clientConnectionManager instanceof ConnPoolControl) {
- pool = (ConnPoolControl) clientConnectionManager;
+ pool = (ConnPoolControl<?>) clientConnectionManager;
}
if (pool != null) {
PoolStats stats = pool.getTotalStats();
@@ -526,9 +527,9 @@ public class HttpEndpoint extends HttpCommonEndpoint {
@ManagedAttribute(description = "Number of connection requests being blocked awaiting a free connection."
+ " This can happen only if there are more worker threads contending for fewer connections.")
public int getClientConnectionsPoolStatsPending() {
- ConnPoolControl pool = null;
+ ConnPoolControl<?> pool = null;
if (clientConnectionManager instanceof ConnPoolControl) {
- pool = (ConnPoolControl) clientConnectionManager;
+ pool = (ConnPoolControl<?>) clientConnectionManager;
}
if (pool != null) {
PoolStats stats = pool.getTotalStats();
diff --git a/components/camel-http4/src/test/java/org/apache/camel/component/http4/CamelComponentVerifierExtensionTest.java b/components/camel-http4/src/test/java/org/apache/camel/component/http4/CamelComponentVerifierExtensionTest.java
index a853919..cad00c5 100644
--- a/components/camel-http4/src/test/java/org/apache/camel/component/http4/CamelComponentVerifierExtensionTest.java
+++ b/components/camel-http4/src/test/java/org/apache/camel/component/http4/CamelComponentVerifierExtensionTest.java
@@ -22,7 +22,6 @@ import java.util.HashMap;
import java.util.Map;
import org.apache.camel.Component;
-import org.apache.camel.ComponentVerifier;
import org.apache.camel.component.extension.ComponentVerifierExtension;
import org.apache.camel.component.http4.handler.AuthenticationValidationHandler;
import org.apache.camel.component.http4.handler.BasicValidationHandler;
@@ -142,9 +141,9 @@ public class CamelComponentVerifierExtensionTest extends BaseHttpTest {
Map<String, Object> parameters = new HashMap<>();
- ComponentVerifier.Result result = verifier.verify(ComponentVerifierExtension.Scope.PARAMETERS, parameters);
+ ComponentVerifierExtension.Result result = verifier.verify(ComponentVerifierExtension.Scope.PARAMETERS, parameters);
- Assert.assertEquals(ComponentVerifier.Result.Status.ERROR, result.getStatus());
+ Assert.assertEquals(ComponentVerifierExtension.Result.Status.ERROR, result.getStatus());
Assert.assertEquals(1, result.getErrors().size());
ComponentVerifierExtension.VerificationError error = result.getErrors().get(0);
diff --git a/components/camel-http4/src/test/java/org/apache/camel/component/http4/CamelComponentVerifierTest.java b/components/camel-http4/src/test/java/org/apache/camel/component/http4/CamelComponentVerifierTest.java
index 5144a8d..721a32c 100644
--- a/components/camel-http4/src/test/java/org/apache/camel/component/http4/CamelComponentVerifierTest.java
+++ b/components/camel-http4/src/test/java/org/apache/camel/component/http4/CamelComponentVerifierTest.java
@@ -21,7 +21,7 @@ import java.util.Arrays;
import java.util.HashMap;
import java.util.Map;
-import org.apache.camel.ComponentVerifier;
+import org.apache.camel.component.extension.ComponentVerifierExtension;
import org.apache.camel.component.http4.handler.AuthenticationValidationHandler;
import org.apache.camel.component.http4.handler.BasicValidationHandler;
import org.apache.http.HttpException;
@@ -123,31 +123,31 @@ public class CamelComponentVerifierTest extends BaseHttpTest {
@Test
public void testParameters() throws Exception {
HttpComponent component = context().getComponent("http4", HttpComponent.class);
- ComponentVerifier verifier = component.getVerifier();
+ ComponentVerifierExtension verifier = component.getVerifier();
Map<String, Object> parameters = new HashMap<>();
parameters.put("httpUri", getLocalServerUri("/basic"));
- ComponentVerifier.Result result = verifier.verify(ComponentVerifier.Scope.PARAMETERS, parameters);
+ ComponentVerifierExtension.Result result = verifier.verify(ComponentVerifierExtension.Scope.PARAMETERS, parameters);
- Assert.assertEquals(ComponentVerifier.Result.Status.OK, result.getStatus());
+ Assert.assertEquals(ComponentVerifierExtension.Result.Status.OK, result.getStatus());
}
@Test
public void testMissingMandatoryParameters() throws Exception {
HttpComponent component = context().getComponent("http4", HttpComponent.class);
- ComponentVerifier verifier = component.getVerifier();
+ ComponentVerifierExtension verifier = component.getVerifier();
Map<String, Object> parameters = new HashMap<>();
- ComponentVerifier.Result result = verifier.verify(ComponentVerifier.Scope.PARAMETERS, parameters);
+ ComponentVerifierExtension.Result result = verifier.verify(ComponentVerifierExtension.Scope.PARAMETERS, parameters);
- Assert.assertEquals(ComponentVerifier.Result.Status.ERROR, result.getStatus());
+ Assert.assertEquals(ComponentVerifierExtension.Result.Status.ERROR, result.getStatus());
Assert.assertEquals(1, result.getErrors().size());
- ComponentVerifier.VerificationError error = result.getErrors().get(0);
+ ComponentVerifierExtension.VerificationError error = result.getErrors().get(0);
- Assert.assertEquals(ComponentVerifier.VerificationError.StandardCode.MISSING_PARAMETER, error.getCode());
+ Assert.assertEquals(ComponentVerifierExtension.VerificationError.StandardCode.MISSING_PARAMETER, error.getCode());
Assert.assertTrue(error.getParameterKeys().contains("httpUri"));
}
@@ -158,69 +158,69 @@ public class CamelComponentVerifierTest extends BaseHttpTest {
@Test
public void testConnectivity() throws Exception {
HttpComponent component = context().getComponent("http4", HttpComponent.class);
- ComponentVerifier verifier = component.getVerifier();
+ ComponentVerifierExtension verifier = component.getVerifier();
Map<String, Object> parameters = new HashMap<>();
parameters.put("httpUri", getLocalServerUri("/basic"));
- ComponentVerifier.Result result = verifier.verify(ComponentVerifier.Scope.CONNECTIVITY, parameters);
+ ComponentVerifierExtension.Result result = verifier.verify(ComponentVerifierExtension.Scope.CONNECTIVITY, parameters);
- Assert.assertEquals(ComponentVerifier.Result.Status.OK, result.getStatus());
+ Assert.assertEquals(ComponentVerifierExtension.Result.Status.OK, result.getStatus());
}
@Test
public void testConnectivityWithWrongUri() throws Exception {
HttpComponent component = context().getComponent("http4", HttpComponent.class);
- ComponentVerifier verifier = component.getVerifier();
+ ComponentVerifierExtension verifier = component.getVerifier();
Map<String, Object> parameters = new HashMap<>();
parameters.put("httpUri", "http://www.not-existing-uri.unknown");
- ComponentVerifier.Result result = verifier.verify(ComponentVerifier.Scope.CONNECTIVITY, parameters);
+ ComponentVerifierExtension.Result result = verifier.verify(ComponentVerifierExtension.Scope.CONNECTIVITY, parameters);
- Assert.assertEquals(ComponentVerifier.Result.Status.ERROR, result.getStatus());
+ Assert.assertEquals(ComponentVerifierExtension.Result.Status.ERROR, result.getStatus());
Assert.assertEquals(1, result.getErrors().size());
- ComponentVerifier.VerificationError error = result.getErrors().get(0);
+ ComponentVerifierExtension.VerificationError error = result.getErrors().get(0);
- Assert.assertEquals(ComponentVerifier.VerificationError.StandardCode.EXCEPTION, error.getCode());
+ Assert.assertEquals(ComponentVerifierExtension.VerificationError.StandardCode.EXCEPTION, error.getCode());
Assert.assertTrue(error.getParameterKeys().contains("httpUri"));
}
@Test
public void testConnectivityWithAuthentication() throws Exception {
HttpComponent component = context().getComponent("http4", HttpComponent.class);
- ComponentVerifier verifier = component.getVerifier();
+ ComponentVerifierExtension verifier = component.getVerifier();
Map<String, Object> parameters = new HashMap<>();
parameters.put("httpUri", getLocalServerUri("/auth"));
parameters.put("authUsername", AUTH_USERNAME);
parameters.put("authPassword", AUTH_PASSWORD);
- ComponentVerifier.Result result = verifier.verify(ComponentVerifier.Scope.CONNECTIVITY, parameters);
+ ComponentVerifierExtension.Result result = verifier.verify(ComponentVerifierExtension.Scope.CONNECTIVITY, parameters);
- Assert.assertEquals(ComponentVerifier.Result.Status.OK, result.getStatus());
+ Assert.assertEquals(ComponentVerifierExtension.Result.Status.OK, result.getStatus());
}
@Test
public void testConnectivityWithWrongAuthenticationData() throws Exception {
HttpComponent component = context().getComponent("http4", HttpComponent.class);
- ComponentVerifier verifier = component.getVerifier();
+ ComponentVerifierExtension verifier = component.getVerifier();
Map<String, Object> parameters = new HashMap<>();
parameters.put("httpUri", getLocalServerUri("/auth"));
parameters.put("authUsername", "unknown");
parameters.put("authPassword", AUTH_PASSWORD);
- ComponentVerifier.Result result = verifier.verify(ComponentVerifier.Scope.CONNECTIVITY, parameters);
+ ComponentVerifierExtension.Result result = verifier.verify(ComponentVerifierExtension.Scope.CONNECTIVITY, parameters);
- Assert.assertEquals(ComponentVerifier.Result.Status.ERROR, result.getStatus());
+ Assert.assertEquals(ComponentVerifierExtension.Result.Status.ERROR, result.getStatus());
Assert.assertEquals(1, result.getErrors().size());
- ComponentVerifier.VerificationError error = result.getErrors().get(0);
+ ComponentVerifierExtension.VerificationError error = result.getErrors().get(0);
- Assert.assertEquals(ComponentVerifier.VerificationError.StandardCode.AUTHENTICATION, error.getCode());
- Assert.assertEquals(401, error.getDetails().get(ComponentVerifier.VerificationError.HttpAttribute.HTTP_CODE));
+ Assert.assertEquals(ComponentVerifierExtension.VerificationError.StandardCode.AUTHENTICATION, error.getCode());
+ Assert.assertEquals(401, error.getDetails().get(ComponentVerifierExtension.VerificationError.HttpAttribute.HTTP_CODE));
Assert.assertTrue(error.getParameterKeys().contains("authUsername"));
Assert.assertTrue(error.getParameterKeys().contains("authPassword"));
}
@@ -228,34 +228,34 @@ public class CamelComponentVerifierTest extends BaseHttpTest {
@Test
public void testConnectivityWithRedirect() throws Exception {
HttpComponent component = context().getComponent("http4", HttpComponent.class);
- ComponentVerifier verifier = component.getVerifier();
+ ComponentVerifierExtension verifier = component.getVerifier();
Map<String, Object> parameters = new HashMap<>();
parameters.put("httpUri", getLocalServerUri("/redirect"));
- ComponentVerifier.Result result = verifier.verify(ComponentVerifier.Scope.CONNECTIVITY, parameters);
+ ComponentVerifierExtension.Result result = verifier.verify(ComponentVerifierExtension.Scope.CONNECTIVITY, parameters);
- Assert.assertEquals(ComponentVerifier.Result.Status.OK, result.getStatus());
+ Assert.assertEquals(ComponentVerifierExtension.Result.Status.OK, result.getStatus());
}
@Test
public void testConnectivityWithRedirectDisabled() throws Exception {
HttpComponent component = context().getComponent("http4", HttpComponent.class);
- ComponentVerifier verifier = component.getVerifier();
+ ComponentVerifierExtension verifier = component.getVerifier();
Map<String, Object> parameters = new HashMap<>();
parameters.put("httpUri", getLocalServerUri("/redirect"));
parameters.put("httpClient.redirectsEnabled", "false");
- ComponentVerifier.Result result = verifier.verify(ComponentVerifier.Scope.CONNECTIVITY, parameters);
+ ComponentVerifierExtension.Result result = verifier.verify(ComponentVerifierExtension.Scope.CONNECTIVITY, parameters);
- Assert.assertEquals(ComponentVerifier.Result.Status.ERROR, result.getStatus());
+ Assert.assertEquals(ComponentVerifierExtension.Result.Status.ERROR, result.getStatus());
Assert.assertEquals(1, result.getErrors().size());
- ComponentVerifier.VerificationError error = result.getErrors().get(0);
+ ComponentVerifierExtension.VerificationError error = result.getErrors().get(0);
- Assert.assertEquals(ComponentVerifier.VerificationError.StandardCode.GENERIC, error.getCode());
- Assert.assertEquals(getLocalServerUri("/redirected"), error.getDetails().get(ComponentVerifier.VerificationError.HttpAttribute.HTTP_REDIRECT));
+ Assert.assertEquals(ComponentVerifierExtension.VerificationError.StandardCode.GENERIC, error.getCode());
+ Assert.assertEquals(getLocalServerUri("/redirected"), error.getDetails().get(ComponentVerifierExtension.VerificationError.HttpAttribute.HTTP_REDIRECT));
Assert.assertTrue(error.getParameterKeys().contains("httpUri"));
}
}
\ No newline at end of file
diff --git a/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsAuthenticationTest.java b/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsAuthenticationTest.java
index 77cfcb1..d5d7b09 100644
--- a/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsAuthenticationTest.java
+++ b/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsAuthenticationTest.java
@@ -25,7 +25,7 @@ import org.apache.camel.component.http4.handler.AuthenticationValidationHandler;
import org.apache.camel.impl.JndiRegistry;
import org.apache.http.HttpRequestInterceptor;
import org.apache.http.HttpResponseInterceptor;
-import org.apache.http.conn.ssl.AllowAllHostnameVerifier;
+import org.apache.http.conn.ssl.NoopHostnameVerifier;
import org.apache.http.impl.bootstrap.HttpServer;
import org.apache.http.impl.bootstrap.ServerBootstrap;
import org.apache.http.localserver.RequestBasicAuth;
@@ -75,7 +75,7 @@ public class HttpsAuthenticationTest extends BaseHttpsTest {
@Override
protected JndiRegistry createRegistry() throws Exception {
JndiRegistry registry = super.createRegistry();
- registry.bind("x509HostnameVerifier", new AllowAllHostnameVerifier());
+ registry.bind("x509HostnameVerifier", new NoopHostnameVerifier());
return registry;
}
diff --git a/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsGetTest.java b/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsGetTest.java
index 5af19c2..413fd6e 100644
--- a/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsGetTest.java
+++ b/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsGetTest.java
@@ -20,7 +20,7 @@ import org.apache.camel.Exchange;
import org.apache.camel.Processor;
import org.apache.camel.component.http4.handler.BasicValidationHandler;
import org.apache.camel.impl.JndiRegistry;
-import org.apache.http.conn.ssl.AllowAllHostnameVerifier;
+import org.apache.http.conn.ssl.NoopHostnameVerifier;
import org.apache.http.impl.bootstrap.HttpServer;
import org.apache.http.impl.bootstrap.ServerBootstrap;
import org.junit.After;
@@ -63,7 +63,7 @@ public class HttpsGetTest extends BaseHttpsTest {
@Override
protected JndiRegistry createRegistry() throws Exception {
JndiRegistry registry = super.createRegistry();
- registry.bind("x509HostnameVerifier", new AllowAllHostnameVerifier());
+ registry.bind("x509HostnameVerifier", new NoopHostnameVerifier());
return registry;
}
diff --git a/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsTwoComponentsSslContextParametersGetTest.java b/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsTwoComponentsSslContextParametersGetTest.java
index 8d7db2e..572526c 100644
--- a/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsTwoComponentsSslContextParametersGetTest.java
+++ b/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsTwoComponentsSslContextParametersGetTest.java
@@ -20,7 +20,7 @@ import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.impl.JndiRegistry;
import org.apache.camel.test.AvailablePortFinder;
import org.apache.camel.util.jsse.SSLContextParameters;
-import org.apache.http.conn.ssl.AllowAllHostnameVerifier;
+import org.apache.http.conn.ssl.NoopHostnameVerifier;
import org.apache.http.impl.bootstrap.HttpServer;
import org.apache.http.impl.bootstrap.ServerBootstrap;
import org.junit.After;
@@ -60,7 +60,7 @@ public class HttpsTwoComponentsSslContextParametersGetTest extends BaseHttpsTest
@Override
protected JndiRegistry createRegistry() throws Exception {
JndiRegistry registry = super.createRegistry();
- registry.bind("x509HostnameVerifier", new AllowAllHostnameVerifier());
+ registry.bind("x509HostnameVerifier", new NoopHostnameVerifier());
registry.bind("sslContextParameters", new SSLContextParameters());
registry.bind("sslContextParameters2", new SSLContextParameters());
diff --git a/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsTwoDifferentSslContextParametersGetTest.java b/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsTwoDifferentSslContextParametersGetTest.java
index 96f732f..7f259cf 100644
--- a/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsTwoDifferentSslContextParametersGetTest.java
+++ b/components/camel-http4/src/test/java/org/apache/camel/component/http4/HttpsTwoDifferentSslContextParametersGetTest.java
@@ -20,7 +20,7 @@ import org.apache.camel.FailedToCreateRouteException;
import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.impl.JndiRegistry;
import org.apache.camel.util.jsse.SSLContextParameters;
-import org.apache.http.conn.ssl.AllowAllHostnameVerifier;
+import org.apache.http.conn.ssl.NoopHostnameVerifier;
import org.apache.http.impl.bootstrap.HttpServer;
import org.apache.http.impl.bootstrap.ServerBootstrap;
import org.junit.After;
@@ -60,7 +60,7 @@ public class HttpsTwoDifferentSslContextParametersGetTest extends BaseHttpsTest
@Override
protected JndiRegistry createRegistry() throws Exception {
JndiRegistry registry = super.createRegistry();
- registry.bind("x509HostnameVerifier", new AllowAllHostnameVerifier());
+ registry.bind("x509HostnameVerifier", new NoopHostnameVerifier());
registry.bind("sslContextParameters", new SSLContextParameters());
registry.bind("sslContextParameters2", new SSLContextParameters());
diff --git a/components/camel-http4/src/test/java/org/apache/camel/component/http4/rest/RestCamelComponentVerifierTest.java b/components/camel-http4/src/test/java/org/apache/camel/component/http4/rest/RestCamelComponentVerifierTest.java
index 7fb540f..8adcfee 100644
--- a/components/camel-http4/src/test/java/org/apache/camel/component/http4/rest/RestCamelComponentVerifierTest.java
+++ b/components/camel-http4/src/test/java/org/apache/camel/component/http4/rest/RestCamelComponentVerifierTest.java
@@ -20,7 +20,7 @@ import java.util.Arrays;
import java.util.HashMap;
import java.util.Map;
-import org.apache.camel.ComponentVerifier;
+import org.apache.camel.component.extension.ComponentVerifierExtension;
import org.apache.camel.component.http4.BaseHttpTest;
import org.apache.camel.component.http4.handler.BasicValidationHandler;
import org.apache.camel.component.rest.RestComponent;
@@ -100,7 +100,7 @@ public class RestCamelComponentVerifierTest extends BaseHttpTest {
@Test
public void testParameters() throws Exception {
RestComponent component = context().getComponent("rest", RestComponent.class);
- ComponentVerifier verifier = component.getVerifier();
+ ComponentVerifierExtension verifier = component.getVerifier();
Map<String, Object> parameters = new HashMap<>();
parameters.put("componentName", "http4");
@@ -108,15 +108,15 @@ public class RestCamelComponentVerifierTest extends BaseHttpTest {
parameters.put("path", "verify");
parameters.put("method", "get");
- ComponentVerifier.Result result = verifier.verify(ComponentVerifier.Scope.PARAMETERS, parameters);
+ ComponentVerifierExtension.Result result = verifier.verify(ComponentVerifierExtension.Scope.PARAMETERS, parameters);
- Assert.assertEquals(ComponentVerifier.Result.Status.OK, result.getStatus());
+ Assert.assertEquals(ComponentVerifierExtension.Result.Status.OK, result.getStatus());
}
@Test
public void testMissingRestParameters() throws Exception {
RestComponent component = context.getComponent("rest", RestComponent.class);
- ComponentVerifier verifier = component.getVerifier();
+ ComponentVerifierExtension verifier = component.getVerifier();
Map<String, Object> parameters = new HashMap<>();
parameters.put("componentName", "http4");
@@ -127,11 +127,11 @@ public class RestCamelComponentVerifierTest extends BaseHttpTest {
// is delegated to the transport component
parameters.put("copyHeaders", false);
- ComponentVerifier.Result result = verifier.verify(ComponentVerifier.Scope.PARAMETERS, parameters);
+ ComponentVerifierExtension.Result result = verifier.verify(ComponentVerifierExtension.Scope.PARAMETERS, parameters);
- Assert.assertEquals(ComponentVerifier.Result.Status.ERROR, result.getStatus());
+ Assert.assertEquals(ComponentVerifierExtension.Result.Status.ERROR, result.getStatus());
Assert.assertEquals(1, result.getErrors().size());
- Assert.assertEquals(ComponentVerifier.VerificationError.StandardCode.MISSING_PARAMETER, result.getErrors().get(0).getCode());
+ Assert.assertEquals(ComponentVerifierExtension.VerificationError.StandardCode.MISSING_PARAMETER, result.getErrors().get(0).getCode());
Assert.assertEquals(1, result.getErrors().get(0).getParameterKeys().size());
Assert.assertTrue(result.getErrors().get(0).getParameterKeys().contains("method"));
}
@@ -139,7 +139,7 @@ public class RestCamelComponentVerifierTest extends BaseHttpTest {
@Test
public void testWrongComponentParameters() throws Exception {
RestComponent component = context.getComponent("rest", RestComponent.class);
- ComponentVerifier verifier = component.getVerifier();
+ ComponentVerifierExtension verifier = component.getVerifier();
Map<String, Object> parameters = new HashMap<>();
parameters.put("componentName", "http4");
@@ -151,11 +151,11 @@ public class RestCamelComponentVerifierTest extends BaseHttpTest {
// is delegated to the transport component
parameters.put("nonExistingOption", true);
- ComponentVerifier.Result result = verifier.verify(ComponentVerifier.Scope.PARAMETERS, parameters);
+ ComponentVerifierExtension.Result result = verifier.verify(ComponentVerifierExtension.Scope.PARAMETERS, parameters);
- Assert.assertEquals(ComponentVerifier.Result.Status.ERROR, result.getStatus());
+ Assert.assertEquals(ComponentVerifierExtension.Result.Status.ERROR, result.getStatus());
Assert.assertEquals(1, result.getErrors().size());
- Assert.assertEquals(ComponentVerifier.VerificationError.StandardCode.UNKNOWN_PARAMETER, result.getErrors().get(0).getCode());
+ Assert.assertEquals(ComponentVerifierExtension.VerificationError.StandardCode.UNKNOWN_PARAMETER, result.getErrors().get(0).getCode());
Assert.assertEquals(1, result.getErrors().get(0).getParameterKeys().size());
Assert.assertTrue(result.getErrors().get(0).getParameterKeys().contains("nonExistingOption"));
}
@@ -163,7 +163,7 @@ public class RestCamelComponentVerifierTest extends BaseHttpTest {
@Test
public void testConnectivity() throws Exception {
RestComponent component = context().getComponent("rest", RestComponent.class);
- ComponentVerifier verifier = component.getVerifier();
+ ComponentVerifierExtension verifier = component.getVerifier();
Map<String, Object> parameters = new HashMap<>();
parameters.put("componentName", "http4");
@@ -171,8 +171,8 @@ public class RestCamelComponentVerifierTest extends BaseHttpTest {
parameters.put("path", "verify");
parameters.put("method", "get");
- ComponentVerifier.Result result = verifier.verify(ComponentVerifier.Scope.CONNECTIVITY, parameters);
+ ComponentVerifierExtension.Result result = verifier.verify(ComponentVerifierExtension.Scope.CONNECTIVITY, parameters);
- Assert.assertEquals(ComponentVerifier.Result.Status.OK, result.getStatus());
+ Assert.assertEquals(ComponentVerifierExtension.Result.Status.OK, result.getStatus());
}
}
\ No newline at end of file