[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #3534: [HUDI-2357] MERGE INTO doesn't work for tables created using CTAS

[GitBox <gi...@apache.org>]

pengzhiwei2018 commented on a change in pull request #3534:
URL: https://github.com/apache/hudi/pull/3534#discussion_r696311825



##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/InsertIntoHoodieTableCommand.scala
##########
@@ -193,15 +193,16 @@ object InsertIntoHoodieTableCommand extends Logging {
         s"[${insertPartitions.keys.mkString(" " )}]" +
         s" not equal to the defined partition in table[${table.partitionColumnNames.mkString(",")}]")
     }
-    val parameters = withSparkConf(sparkSession, table.storage.properties)() ++ extraOptions
+    val options = table.storage.properties ++ extraOptions

Review comment:
       Yes, we have the UT for merge with a CTAS table. But this bug happen only for hive meta client because we have missed some hive table properties before this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org