You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "lordrip (via GitHub)" <gi...@apache.org> on 2024/02/26 17:22:06 UTC
[PR] fix(typo): Small typos in properties description [camel]
lordrip opened a new pull request, #13312:
URL: https://github.com/apache/camel/pull/13312
# Description
This commit fixes a couple of typos:
* Beans: Sets a reference to an _exiting_ bean to use, which is looked up from the registry
* OnException: Turn on exponential _backk_ off
In addition to that, a missing `enum` annotation was added to the LogLevel of `retriesExhaustedLogLevel`
# Target
- [X] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [X] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
[CAMEL-20462](https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-20462)
[#865](https://github.com/KaotoIO/kaoto-next/issues/865)
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [X] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [X] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(typo): Small typos in properties description [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #13312:
URL: https://github.com/apache/camel/pull/13312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(typo): Small typos in properties description [camel]
Posted by "lhein (via GitHub)" <gi...@apache.org>.
lhein commented on code in PR #13312:
URL: https://github.com/apache/camel/pull/13312#discussion_r1503675932
##########
catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/models/redeliveryPolicy.json:
##########
@@ -17,12 +17,12 @@
"redeliveryDelay": { "index": 2, "kind": "attribute", "displayName": "Redelivery Delay", "required": false, "type": "duration", "javaType": "java.lang.String", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "1000", "description": "Sets the initial redelivery delay" },
"asyncDelayedRedelivery": { "index": 3, "kind": "attribute", "displayName": "Async Delayed Redelivery", "label": "advanced", "required": false, "type": "boolean", "javaType": "java.lang.Boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "Allow asynchronous delayed redelivery. The route, in particular the consumer's component, must support the Asynchronous Routing Engine (e.g. seda)." },
"backOffMultiplier": { "index": 4, "kind": "attribute", "displayName": "Back Off Multiplier", "required": false, "type": "number", "javaType": "java.lang.Double", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "2.0", "description": "Sets the back off multiplier" },
- "useExponentialBackOff": { "index": 5, "kind": "attribute", "displayName": "Use Exponential Back Off", "label": "advanced", "required": false, "type": "boolean", "javaType": "java.lang.Boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "Turn on exponential backk off" },
+ "useExponentialBackOff": { "index": 5, "kind": "attribute", "displayName": "Use Exponential Back Off", "label": "advanced", "required": false, "type": "boolean", "javaType": "java.lang.Boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "Turn on exponential back off" },
"collisionAvoidanceFactor": { "index": 6, "kind": "attribute", "displayName": "Collision Avoidance Factor", "label": "advanced", "required": false, "type": "number", "javaType": "java.lang.Double", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "0.15", "description": "Sets the collision avoidance factor" },
"useCollisionAvoidance": { "index": 7, "kind": "attribute", "displayName": "Use Collision Avoidance", "label": "advanced", "required": false, "type": "boolean", "javaType": "java.lang.Boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "Turn on collision avoidance." },
"maximumRedeliveryDelay": { "index": 8, "kind": "attribute", "displayName": "Maximum Redelivery Delay", "required": false, "type": "duration", "javaType": "java.lang.String", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "60000", "description": "Sets the maximum delay between redelivery" },
- "retriesExhaustedLogLevel": { "index": 9, "kind": "attribute", "displayName": "Retries Exhausted Log Level", "label": "advanced", "required": false, "type": "object", "javaType": "org.apache.camel.LoggingLevel", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "ERROR", "description": "Sets the logging level to use when retries have been exhausted" },
- "retryAttemptedLogLevel": { "index": 10, "kind": "attribute", "displayName": "Retry Attempted Log Level", "required": false, "type": "object", "javaType": "org.apache.camel.LoggingLevel", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "DEBUG", "description": "Sets the logging level to use for logging retry attempts" },
+ "retriesExhaustedLogLevel": { "index": 9, "kind": "attribute", "displayName": "Retries Exhausted Log Level", "label": "advanced", "required": false, "type": "enum", "javaType": "org.apache.camel.LoggingLevel", "enum": [ "TRACE", "DEBUG", "INFO", "WARN", "ERROR", "OFF" ], "deprecated": false, "autowired": false, "secret": false, "defaultValue": "ERROR", "description": "Sets the logging level to use when retries have been exhausted" },
Review Comment:
ah I see the difference to https://github.com/apache/camel/pull/13312/files#diff-df860c9ccdcd78a71b9e096d18c329d0559d700d40c4cda5be053025444df3cf so this seems fine then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(typo): Small typos in properties description [camel]
Posted by "lordrip (via GitHub)" <gi...@apache.org>.
lordrip commented on PR #13312:
URL: https://github.com/apache/camel/pull/13312#issuecomment-1966130509
> LGTM, but ... maybe, it would be great to write the commit messages in the following format:
>
> ```
> CAMEL-20462: small typos in properties description
>
> <longer description here>
> ```
>
> That way, it gets linked automatically in the Jira ticket. It makes our life much easier ...
Absolutely, I'll rename the commit, just a sec 👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(typo): Small typos in properties description [camel]
Posted by "lordrip (via GitHub)" <gi...@apache.org>.
lordrip commented on PR #13312:
URL: https://github.com/apache/camel/pull/13312#issuecomment-1966135808
I redid the changes using Fedora instead, so now the diff looks cleaner 👍 , sorry for the noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(typo): Small typos in properties description [camel]
Posted by "lhein (via GitHub)" <gi...@apache.org>.
lhein commented on code in PR #13312:
URL: https://github.com/apache/camel/pull/13312#discussion_r1503672519
##########
catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/models/redeliveryPolicy.json:
##########
@@ -17,12 +17,12 @@
"redeliveryDelay": { "index": 2, "kind": "attribute", "displayName": "Redelivery Delay", "required": false, "type": "duration", "javaType": "java.lang.String", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "1000", "description": "Sets the initial redelivery delay" },
"asyncDelayedRedelivery": { "index": 3, "kind": "attribute", "displayName": "Async Delayed Redelivery", "label": "advanced", "required": false, "type": "boolean", "javaType": "java.lang.Boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "Allow asynchronous delayed redelivery. The route, in particular the consumer's component, must support the Asynchronous Routing Engine (e.g. seda)." },
"backOffMultiplier": { "index": 4, "kind": "attribute", "displayName": "Back Off Multiplier", "required": false, "type": "number", "javaType": "java.lang.Double", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "2.0", "description": "Sets the back off multiplier" },
- "useExponentialBackOff": { "index": 5, "kind": "attribute", "displayName": "Use Exponential Back Off", "label": "advanced", "required": false, "type": "boolean", "javaType": "java.lang.Boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "Turn on exponential backk off" },
+ "useExponentialBackOff": { "index": 5, "kind": "attribute", "displayName": "Use Exponential Back Off", "label": "advanced", "required": false, "type": "boolean", "javaType": "java.lang.Boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "Turn on exponential back off" },
"collisionAvoidanceFactor": { "index": 6, "kind": "attribute", "displayName": "Collision Avoidance Factor", "label": "advanced", "required": false, "type": "number", "javaType": "java.lang.Double", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "0.15", "description": "Sets the collision avoidance factor" },
"useCollisionAvoidance": { "index": 7, "kind": "attribute", "displayName": "Use Collision Avoidance", "label": "advanced", "required": false, "type": "boolean", "javaType": "java.lang.Boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "Turn on collision avoidance." },
"maximumRedeliveryDelay": { "index": 8, "kind": "attribute", "displayName": "Maximum Redelivery Delay", "required": false, "type": "duration", "javaType": "java.lang.String", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "60000", "description": "Sets the maximum delay between redelivery" },
- "retriesExhaustedLogLevel": { "index": 9, "kind": "attribute", "displayName": "Retries Exhausted Log Level", "label": "advanced", "required": false, "type": "object", "javaType": "org.apache.camel.LoggingLevel", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "ERROR", "description": "Sets the logging level to use when retries have been exhausted" },
- "retryAttemptedLogLevel": { "index": 10, "kind": "attribute", "displayName": "Retry Attempted Log Level", "required": false, "type": "object", "javaType": "org.apache.camel.LoggingLevel", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "DEBUG", "description": "Sets the logging level to use for logging retry attempts" },
+ "retriesExhaustedLogLevel": { "index": 9, "kind": "attribute", "displayName": "Retries Exhausted Log Level", "label": "advanced", "required": false, "type": "enum", "javaType": "org.apache.camel.LoggingLevel", "enum": [ "TRACE", "DEBUG", "INFO", "WARN", "ERROR", "OFF" ], "deprecated": false, "autowired": false, "secret": false, "defaultValue": "ERROR", "description": "Sets the logging level to use when retries have been exhausted" },
Review Comment:
You changed the default for `retriesExhaustedLogLevel` from `DEBUG` to `ERROR`. Is that intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(typo): Small typos in properties description [camel]
Posted by "lhein (via GitHub)" <gi...@apache.org>.
lhein commented on code in PR #13312:
URL: https://github.com/apache/camel/pull/13312#discussion_r1503673766
##########
components/camel-sql/src/generated/java/org/apache/camel/component/sql/stored/template/generated/SSPTParserConstants.java:
##########
@@ -1,67 +1,67 @@
-/* Generated By:JavaCC: Do not edit this line. SSPTParserConstants.java */
-package org.apache.camel.component.sql.stored.template.generated;
-
-
-/**
- * Token literal values and constants.
- * Generated by org.javacc.parser.OtherFilesGen#start()
- */
-public interface SSPTParserConstants {
-
- /** End of File. */
- int EOF = 0;
- /** RegularExpression Id. */
- int SCALE = 4;
- /** RegularExpression Id. */
- int NUMBER = 5;
- /** RegularExpression Id. */
- int DIGIT = 6;
- /** RegularExpression Id. */
- int LETTER = 7;
- /** RegularExpression Id. */
- int SPECIAL = 8;
- /** RegularExpression Id. */
- int WHITESPACE = 9;
- /** RegularExpression Id. */
- int COMMA = 10;
- /** RegularExpression Id. */
- int SEPARATOR = 11;
- /** RegularExpression Id. */
- int PROCEDURE_BEGIN = 12;
- /** RegularExpression Id. */
- int PROCEDURE_END = 13;
- /** RegularExpression Id. */
- int SIMPLE_EXP_TOKEN = 14;
- /** RegularExpression Id. */
- int PARAMETER_POS_TOKEN = 15;
- /** RegularExpression Id. */
- int PARAMETER_NAME = 16;
- /** RegularExpression Id. */
- int IDENTIFIER = 17;
-
- /** Lexical state. */
- int DEFAULT = 0;
-
- /** Literal token values. */
- String[] tokenImage = {
- "<EOF>",
- "\" \"",
- "\"OUT \"",
- "\"INOUT \"",
- "<SCALE>",
- "<NUMBER>",
- "<DIGIT>",
- "<LETTER>",
- "<SPECIAL>",
- "<WHITESPACE>",
- "\",\"",
- "<SEPARATOR>",
- "<PROCEDURE_BEGIN>",
- "<PROCEDURE_END>",
- "<SIMPLE_EXP_TOKEN>",
- "<PARAMETER_POS_TOKEN>",
- "<PARAMETER_NAME>",
- "<IDENTIFIER>",
- };
-
-}
+/* Generated By:JavaCC: Do not edit this line. SSPTParserConstants.java */
Review Comment:
What changed in that file? Maybe a code formatting thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(typo): Small typos in properties description [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13312:
URL: https://github.com/apache/camel/pull/13312#issuecomment-1964698276
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(typo): Small typos in properties description [camel]
Posted by "lordrip (via GitHub)" <gi...@apache.org>.
lordrip commented on PR #13312:
URL: https://github.com/apache/camel/pull/13312#issuecomment-1964702440
I have doubts regarding the autogenerated changes, are the following files intended?:
* `bom/camel-bom/pom.xml`
* components/camel-debezium/camel-debezium-oracle/src/generated/java/org/apache/camel/component/debezium/configuration/OracleConnectorEmbeddedDebeziumConfiguration.java
* components/camel-sql/src/generated/java/org/apache/camel/component/sql/stored/template/generated/SSPTParserTokenManager.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(typo): Small typos in properties description [camel]
Posted by "lordrip (via GitHub)" <gi...@apache.org>.
lordrip commented on PR #13312:
URL: https://github.com/apache/camel/pull/13312#issuecomment-1966083038
> I have doubts regarding the autogenerated changes, are the following files intended?:
>
> * `bom/camel-bom/pom.xml`
>
> * components/camel-debezium/camel-debezium-oracle/src/generated/java/org/apache/camel/component/debezium/configuration/OracleConnectorEmbeddedDebeziumConfiguration.java
>
> * components/camel-sql/src/generated/java/org/apache/camel/component/sql/stored/template/generated/SSPTParserTokenManager.java
It turns out that it was a line termination change, I've updated the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org