[GitHub] [accumulo] dlmarion commented on a diff in pull request #3276: Optimize internal data structures in Authorizations

["dlmarion (via GitHub)" <gi...@apache.org>]

dlmarion commented on code in PR #3276:
URL: https://github.com/apache/accumulo/pull/3276#discussion_r1157602532


##########
core/src/main/java/org/apache/accumulo/core/security/Authorizations.java:
##########
@@ -112,6 +112,8 @@ private void checkAuths() {
    */
   public Authorizations(Collection<byte[]> authorizations) {
     checkArgument(authorizations != null, "authorizations is null");
+    this.auths = new HashSet<>(authorizations.size());
+    this.authsList = new ArrayList<>(authorizations.size());

Review Comment:
   `Set.of` and `List.of` don't exist in Java 8. I did implement your idea in f398f1d though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org