You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/02 07:09:20 UTC
[GitHub] [spark] HeartSaVioR commented on issue #25996: [SPARK-29322][CORE]
Enable closeFrameOnFlush on ZstdOutputStream for event log file
HeartSaVioR commented on issue #25996: [SPARK-29322][CORE] Enable closeFrameOnFlush on ZstdOutputStream for event log file
URL: https://github.com/apache/spark/pull/25996#issuecomment-537366332
If we prefer having UT, we might be able to simulate the case (actually I have one) and see whether it finishes within timeout. It doesn't test the specific functionality so not sure we would like to add it. Please let me know if we want to add it. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org