[GitHub] [incubator-zipkin] wuchenglong1 commented on issue #2626: zipkin 使用brave拦截RPC异步请求影响业务代码的问题

[GitBox <gi...@apache.org>]

wuchenglong1 commented on issue #2626: zipkin 使用brave拦截RPC异步请求影响业务代码的问题
URL: https://github.com/apache/incubator-zipkin/issues/2626#issuecomment-501143223
 
 
   i mean that the following codes of the TracingFilter.class affect my own business codes：
   
   Futurefuture=rpcContext.getFuture();
   if(future instanceof FutureAdapter){
   deferFinish=true;
   ((FutureAdapter)future).getFuture().setCallback(new FinishSpanCallback(span));
   }
   
   the above codes why can affect my own business's callback result ? it means that it will transfer span to async callback method and if async callback method finish ,the span will record finish, or else lock , and will this behaviour lead to business's thread timeout??? 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services