You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by jyotiska <gi...@git.apache.org> on 2014/02/27 15:37:20 UTC
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
GitHub user jyotiska opened a pull request:
https://github.com/apache/spark/pull/34
[SPARK-972] Added detailed callsite info for ValueError in context.py
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jyotiska/spark pyspark_code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit a6bf4cd0e7ed86a4ca19d4d240ae87c95d54642e
Author: jyotiska <jy...@gmail.com>
Date: 2014-02-27T14:13:19Z
added callsite info for context.py
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36580331
Sure, named tuple sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36482065
@mateiz Do you think this is a good case for a [namedtuple](http://docs.python.org/2/library/collections.html#collections.namedtuple)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36753067
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13006/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36250828
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12919/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36250827
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36747330
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by jyotiska <gi...@git.apache.org>.
Github user jyotiska commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36825757
@mateiz @JoshRosen Can you verify this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36247626
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36753065
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark issue #34: [SPARK-972] Added detailed callsite info for ValueError in ...
Posted by databricks-jenkins <gi...@git.apache.org>.
Github user databricks-jenkins commented on the issue:
https://github.com/apache/spark/pull/34
**[Test build #49 has started](https://jenkins.test.databricks.com/job/spark-pull-request-builder/49/consoleFull)** for PR 34 at commit [`f5ea08c`](https://github.com/apache/spark/commit/f5ea08c449cdf72788251fed47c62e0a8045637e).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36481386
@jyotiska instead of passing a dictionary around, could you make a class to represent a call site? It will be a bit clearer and harder to get wrong when someone's changing this code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark issue #34: [SPARK-972] Added detailed callsite info for ValueError in ...
Posted by databricks-jenkins <gi...@git.apache.org>.
Github user databricks-jenkins commented on the issue:
https://github.com/apache/spark/pull/34
**[Test build #49 has finished](https://jenkins.test.databricks.com/job/spark-pull-request-builder/49/consoleFull)** for PR 34 at commit [`f5ea08c`](https://github.com/apache/spark/commit/f5ea08c449cdf72788251fed47c62e0a8045637e).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #34: [SPARK-972] Added detailed callsite info for ValueError in ...
Posted by databricks-jenkins <gi...@git.apache.org>.
Github user databricks-jenkins commented on the issue:
https://github.com/apache/spark/pull/34
**[Test build #50 has finished](https://jenkins.test.databricks.com/job/spark-pull-request-builder/50/consoleFull)** for PR 34 at commit [`3232768`](https://github.com/apache/spark/commit/3232768793b5b8e4f3142a2708f283a3476a511a).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #34: [SPARK-972] Added detailed callsite info for ValueError in ...
Posted by databricks-jenkins <gi...@git.apache.org>.
Github user databricks-jenkins commented on the issue:
https://github.com/apache/spark/pull/34
**[Test build #48 has finished](https://jenkins.test.databricks.com/job/spark-pull-request-builder/48/consoleFull)** for PR 34 at commit [`30bda81`](https://github.com/apache/spark/commit/30bda8158e0fa53a6f39bc6ce5309b4b64c15a72).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-37230775
Sorry for the late reply; I've now merged this. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36747331
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by jyotiska <gi...@git.apache.org>.
Github user jyotiska commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36484436
I think namedtuple will be more suitable. @mateiz What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark issue #34: [SPARK-972] Added detailed callsite info for ValueError in ...
Posted by databricks-jenkins <gi...@git.apache.org>.
Github user databricks-jenkins commented on the issue:
https://github.com/apache/spark/pull/34
**[Test build #48 has started](https://jenkins.test.databricks.com/job/spark-pull-request-builder/48/consoleFull)** for PR 34 at commit [`30bda81`](https://github.com/apache/spark/commit/30bda8158e0fa53a6f39bc6ce5309b4b64c15a72).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #34: [SPARK-972] Added detailed callsite info for ValueError in ...
Posted by databricks-jenkins <gi...@git.apache.org>.
Github user databricks-jenkins commented on the issue:
https://github.com/apache/spark/pull/34
**[Test build #51 has finished](https://jenkins.test.databricks.com/job/spark-pull-request-builder/51/consoleFull)** for PR 34 at commit [`19d5742`](https://github.com/apache/spark/commit/19d5742a68aed2f6509481846d06de9a2b9de3fd).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class Event(user_id: String, page_id: String, ad_id: String, ad_type: String,`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36247606
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36247608
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark issue #34: [SPARK-972] Added detailed callsite info for ValueError in ...
Posted by databricks-jenkins <gi...@git.apache.org>.
Github user databricks-jenkins commented on the issue:
https://github.com/apache/spark/pull/34
**[Test build #51 has started](https://jenkins.test.databricks.com/job/spark-pull-request-builder/51/consoleFull)** for PR 34 at commit [`19d5742`](https://github.com/apache/spark/commit/19d5742a68aed2f6509481846d06de9a2b9de3fd).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #34: [SPARK-972] Added detailed callsite info for ValueError in ...
Posted by databricks-jenkins <gi...@git.apache.org>.
Github user databricks-jenkins commented on the issue:
https://github.com/apache/spark/pull/34
**[Test build #50 has started](https://jenkins.test.databricks.com/job/spark-pull-request-builder/50/consoleFull)** for PR 34 at commit [`3232768`](https://github.com/apache/spark/commit/3232768793b5b8e4f3142a2708f283a3476a511a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-972] Added detailed callsite info for V...
Posted by jyotiska <gi...@git.apache.org>.
Github user jyotiska commented on the pull request:
https://github.com/apache/spark/pull/34#issuecomment-36414522
Can one of the admins look into this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---