You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/05/26 08:45:42 UTC

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10041: IGNITE-17035 Fixed flaky testChangeSnapshotTransferRateInRuntime test.

NSAmelchev commented on code in PR #10041:
URL: https://github.com/apache/ignite/pull/10041#discussion_r882455372


##########
modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerTest.java:
##########
@@ -3032,6 +3035,12 @@ public void testChangeSnapshotTransferRateInRuntime() throws Exception {
         // Set transfer rate to unlimited.
         assertEquals(EXIT_CODE_OK, (int)propFunc.apply(0));
 
+        // Add release time of BasicRateLimiter#acquire() for the given rate.
+        BasicRateLimiter limiter = new BasicRateLimiter(rate);
+
+        limiter.acquire(SNAPSHOT_LIMITED_TRANSFER_BLOCK_SIZE_BYTES);

Review Comment:
   Hi. `acquire` is about block size, not about rate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org