You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/04/26 15:35:12 UTC
[GitHub] [maven-docck-plugin] timtebeek opened a new pull request #1: [MDOCCK-35] - Upgrade Http Client
timtebeek opened a new pull request #1:
URL: https://github.com/apache/maven-docck-plugin/pull/1
For https://issues.apache.org/jira/browse/MDOCCK-35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-docck-plugin] timtebeek commented on pull request #1: [MDOCCK-35] - Upgrade Http Client
Posted by GitBox <gi...@apache.org>.
timtebeek commented on pull request #1:
URL: https://github.com/apache/maven-docck-plugin/pull/1#issuecomment-833469892
Posted some comments in the issue, which might be best to repeat here to ensure they're seen before a merge:
> Had to move HttpClient builder to execute method, as proxy setup was in execute.
> Following redirects seems to be the default, hence no direct 1 to 1 replacement for that.
> The only thing I couldn't work out a direct parallel for was preemptive authentication with the proxy.
There might be some hints in here if that's still needed:
https://github.com/apache/httpcomponents-client/blob/5.0.x/httpclient5/src/test/java/org/apache/hc/client5/http/examples/ClientPreemptiveBasicAuthentication.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-docck-plugin] MartinKanters commented on pull request #1: [MDOCCK-35] - Upgrade Http Client
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on pull request #1:
URL: https://github.com/apache/maven-docck-plugin/pull/1#issuecomment-841092121
Thanks for contributing @timtebeek !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-docck-plugin] MartinKanters commented on pull request #1: [MDOCCK-35] - Upgrade Http Client
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on pull request #1:
URL: https://github.com/apache/maven-docck-plugin/pull/1#issuecomment-841091744
Thanks @timtebeek for the extra warning. Preemptive authentication are things I did not know about yet, so before merging I wanted to make sure that nothing would break. I've tested the 1.1 build and yours against a local proxy with authentication to check the differences. My test target was the maven-help-plugin. Both showed the following warnings in the logs per host:
```
May 14, 2021 9:43:58 AM org.apache.commons.httpclient.HttpMethodDirector authenticateHost
WARNING: Required credentials not available for BASIC <any realm>@www.apache.org:443
May 14, 2021 9:43:58 AM org.apache.commons.httpclient.HttpMethodDirector authenticateHost
WARNING: Preemptive authentication requested but no default credentials available
```
The authentication however works fine in the end, and since there is no functional regression between the two, I'm going ahead and merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-docck-plugin] MartinKanters merged pull request #1: [MDOCCK-35] - Upgrade Http Client
Posted by GitBox <gi...@apache.org>.
MartinKanters merged pull request #1:
URL: https://github.com/apache/maven-docck-plugin/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-docck-plugin] MartinKanters commented on pull request #1: [MDOCCK-35] - Upgrade Http Client
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on pull request #1:
URL: https://github.com/apache/maven-docck-plugin/pull/1#issuecomment-841105436
I've made a mistake while testing. So I redid the testing and luckily still did not find any regression. The warning logs I mentioned before are gone now, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org