[GitHub] [flink-connector-dynamodb] dannycranmer commented on a diff in pull request #8: [FLINK-29310] Added license check

[GitBox <gi...@apache.org>]

dannycranmer commented on code in PR #8:
URL: https://github.com/apache/flink-connector-dynamodb/pull/8#discussion_r991016955


##########
pom.xml:
##########
@@ -83,6 +83,35 @@ under the License.
 
 	<build>
 		<plugins>
+			<plugin>
+				<groupId>org.codehaus.mojo</groupId>
+				<artifactId>exec-maven-plugin</artifactId>
+				<version>3.1.0</version>
+				<inherited>false</inherited>
+				<executions>
+					<execution>
+						<id>check-license</id>
+						<!-- manually called -->
+						<phase>none</phase>
+						<goals>
+							<goal>java</goal>
+						</goals>
+					</execution>
+				</executions>
+				<configuration>
+					<mainClass>org.apache.flink.tools.ci.licensecheck.LicenseChecker</mainClass>
+					<includePluginDependencies>true</includePluginDependencies>
+					<includeProjectDependencies>false</includeProjectDependencies>
+				</configuration>
+				<dependencies>
+					<dependency>
+						<groupId>org.apache.flink</groupId>
+						<artifactId>flink-ci-tools</artifactId>
+						<version>1.15-SNAPSHOT</version>

Review Comment:
   Can we not use the Flink parent version here?



##########
pom.xml:
##########
@@ -83,6 +83,35 @@ under the License.
 
 	<build>
 		<plugins>
+			<plugin>
+				<groupId>org.codehaus.mojo</groupId>
+				<artifactId>exec-maven-plugin</artifactId>
+				<version>3.1.0</version>
+				<inherited>false</inherited>

Review Comment:
   Can we inherit any of this, plus config, from the parent pom?



##########
.github/workflows/ci.yml:
##########
@@ -25,7 +25,11 @@ jobs:
       matrix:
         jdk: [8, 11]
     env:
+      MVN_COMMON_OPTIONS: -U -B --no-transfer-progress
       MVN_CONNECTION_OPTIONS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
+      FLINK_URL: https://s3.amazonaws.com/flink-nightly/flink-1.15-SNAPSHOT-bin-scala_2.12.tgz

Review Comment:
   Why are we pointing at Flink 1.15-SNAPSHOT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org