You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/03/10 23:29:33 UTC

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2342: Force fully qualified endpoint names

wu-sheng commented on issue #2342: Force fully qualified endpoint names
URL: https://github.com/apache/incubator-skywalking/issues/2342#issuecomment-471365242
 
 
   This change should be easy, I want to know,  do you think, does `GET/` and `POST/` make more sense? Because I think the basic issue is how to make get/post difference. If YES, then I will support to make this as default, rather than using `Config.Agent.FORCE_FULLY_QUALIFIED_ENDPOINT_NAMES` setting.
   
   > You will end up with more endpoints in SkyWalking
   
   This is fine, I think. Millions of endpoints are supported in production env.
   
   We are using the class name in some RPC frameworks, such as gRPC, Dubbo, etc. `Config.Agent.FORCE_FULLY_QUALIFIED_ENDPOINT_NAMES` looks like should be named as `Config.Plugin.SpringMVC.USE_CLASSNAME_AS_ENDPOINT_NAME`(so something like this)
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services