You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/05/07 12:20:29 UTC
[GitHub] [phoenix] stoty opened a new pull request #1227: PHOENIX-6357 Change all command line tools to use the fixed commons-c…
stoty opened a new pull request #1227:
URL: https://github.com/apache/phoenix/pull/1227
…li constructor
note that this also removes the partial double doublequote workaround, as it is no longer needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1227: PHOENIX-6357 Change all command line tools to use the fixed commons-c…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1227:
URL: https://github.com/apache/phoenix/pull/1227#issuecomment-834604401
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 8s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 9s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 15s | 4.x passed |
| +1 :green_heart: | compile | 2m 15s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 30s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 17s | 4.x passed |
| +0 :ok: | spotbugs | 3m 18s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 56s | phoenix-pherf in 4.x has 51 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 47s | phoenix-tools in 4.x has 3 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 3s | the patch passed |
| +1 :green_heart: | compile | 2m 16s | the patch passed |
| +1 :green_heart: | javac | 2m 16s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 7s | phoenix-core: The patch generated 0 new + 2557 unchanged - 13 fixed = 2557 total (was 2570) |
| +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in phoenix-pherf |
| +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in phoenix-tools |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 1m 16s | the patch passed |
| +1 :green_heart: | spotbugs | 5m 33s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 197m 53s | phoenix-core in the patch passed. |
| -1 :x: | unit | 7m 44s | phoenix-pherf in the patch failed. |
| +1 :green_heart: | unit | 3m 48s | phoenix-tools in the patch passed. |
| +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. |
| | | 255m 44s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.pherf.PherfMainIT |
| | phoenix.pherf.workload.mt.tenantoperation.TenantViewOperationWorkloadIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1227/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1227 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 3b15a3f4cc4c 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / ddc3996 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1227/1/artifact/yetus-general-check/output/patch-unit-phoenix-pherf.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1227/1/testReport/ |
| Max. process+thread count | 5152 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf phoenix-tools U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1227/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1227: PHOENIX-6357 Change all command line tools to use the fixed commons-c…
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #1227:
URL: https://github.com/apache/phoenix/pull/1227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org