[GitHub] [iceberg] rdblue commented on a diff in pull request #7886: Spark 3.4: Support pushing down system functions by V2 filters

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #7886:
URL: https://github.com/apache/iceberg/pull/7886#discussion_r1240434980


##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestFilteredScan.java:
##########
@@ -600,10 +602,10 @@ private List<Record> expected(int... ordinals) {
     return expected;
   }
 
-  private void pushFilters(ScanBuilder scan, Filter... filters) {
-    Assertions.assertThat(scan).isInstanceOf(SupportsPushDownFilters.class);
-    SupportsPushDownFilters filterable = (SupportsPushDownFilters) scan;
-    filterable.pushFilters(filters);
+  private void pushFilters(ScanBuilder scan, Predicate... predicates) {

Review Comment:
   Why add `.toV2` everywhere instead of just calling it here? Seems like this would be an easier place to update.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org