You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by ku...@apache.org on 2009/05/23 20:45:25 UTC
svn commit: r777983 -
/incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php
Author: kurdalen
Date: Sat May 23 18:45:25 2009
New Revision: 777983
URL: http://svn.apache.org/viewvc?rev=777983&view=rev
Log:
fixed access level to LoggerLoggingEventTestCaseAppender::append()
Modified:
incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php
Modified: incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php?rev=777983&r1=777982&r2=777983&view=diff
==============================================================================
--- incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php (original)
+++ incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php Sat May 23 18:45:25 2009
@@ -27,7 +27,7 @@
protected $requiresLayout = true;
- protected function append($event) {
+ public function append($event) {
$this->layout->format($event);
}
Re: svn commit: r777983 - /incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php
Posted by Christian Grobmeier <gr...@gmail.com>.
>> Any idea why this happened? I can reproduce this behaviour on two
>> different macs, one with 10.4 and one with 10.5
>>
> I have no idea why this is/was inconsistent for you. To me I got it when
> running the whole test suite with simply typing "phpunit" in src/test/php.
Strange... phpUnderControl says its running Unit Tests: (62).
Local are Tests: 78 running.
I have 16 more than phpUnderControl... I will try to figure out which
testcases are not running under phpUnderControl when I have cycles
left. That makes me a bit anxious
Cheers,
Christin
Re: svn commit: r777983 - /incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php
Posted by Knut Urdalen <kn...@php.no>.
Christian Grobmeier wrote:
> just one question: i ran all the test locally with success. The error
> below didn't show up to me.
> But why? I expierenced the same behaviour with LoggerHierarchyTest.
> When calling it directly, it failed. But calling all tests worked
> perfectly.
> Any idea why this happened? I can reproduce this behaviour on two
> different macs, one with 10.4 and one with 10.5
>
I have no idea why this is/was inconsistent for you. To me I got it when
running the whole test suite with simply typing "phpunit" in src/test/php.
Knut
Re: svn commit: r777983 - /incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php
Posted by Christian Grobmeier <gr...@gmail.com>.
Hi,
just one question: i ran all the test locally with success. The error
below didn't show up to me.
But why? I expierenced the same behaviour with LoggerHierarchyTest.
When calling it directly, it failed. But calling all tests worked
perfectly.
Any idea why this happened? I can reproduce this behaviour on two
different macs, one with 10.4 and one with 10.5
Cheers
Christian
On Sat, May 23, 2009 at 8:45 PM, <ku...@apache.org> wrote:
> Author: kurdalen
> Date: Sat May 23 18:45:25 2009
> New Revision: 777983
>
> URL: http://svn.apache.org/viewvc?rev=777983&view=rev
> Log:
> fixed access level to LoggerLoggingEventTestCaseAppender::append()
>
> Modified:
> incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php
>
> Modified: incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php
> URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php?rev=777983&r1=777982&r2=777983&view=diff
> ==============================================================================
> --- incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php (original)
> +++ incubator/log4php/trunk/src/test/php/LoggerLoggingEventTest.php Sat May 23 18:45:25 2009
> @@ -27,7 +27,7 @@
>
> protected $requiresLayout = true;
>
> - protected function append($event) {
> + public function append($event) {
> $this->layout->format($event);
> }
>
>
>
>