You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by "Balu Vellanki (JIRA)" <ji...@apache.org> on 2015/09/11 17:38:45 UTC
[jira] [Comment Edited] (FALCON-1250) Throw error when keys in
startup.properties do not start with "*." or domain+"."
[ https://issues.apache.org/jira/browse/FALCON-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740988#comment-14740988 ]
Balu Vellanki edited comment on FALCON-1250 at 9/11/15 3:37 PM:
----------------------------------------------------------------
[~pallavi.rao] : You convinced me with respect to the value of having multiple properties for multiple domains co-exist in same file.
The next question is - is it worth trying to catch customer typos early on by having a set of allowed domains like "falcon, prism, debug" OR is this an overkill? My initial thoughts were that this jira would increase usability and reduce time spent on debugging typos.
So if you think it is overkill, we can close the Jira. I am comfortable with not solving this issue since this Jira is an enhancement and not an actual bug.
was (Author: bvellanki):
[~pallavi.rao] : You convinced me with respect to the value of having multiple properties for multiple domains co-exist in same file.
The next question is - is it worth trying to catch customer typos early on by having a set of allowed domains like "falcon, prism, debug" OR is this an overkill? My initial thoughts were that this jira would increase usability and reduce time spent on debugging typos.
So if you think it is overkill, we can close the Jira. I am comfortable with not solving this issue.
> Throw error when keys in startup.properties do not start with "*." or domain+"."
> --------------------------------------------------------------------------------
>
> Key: FALCON-1250
> URL: https://issues.apache.org/jira/browse/FALCON-1250
> Project: Falcon
> Issue Type: Improvement
> Reporter: Balu Vellanki
> Assignee: Narayan Periwal
> Fix For: trunk
>
> Attachments: FALCON-1250-v0.patch
>
>
> In org.apache.falcon.util.ApplicationProperties.java, method doLoadProperties only loads the keys that start with domain + "." or "*.". All other keys are ignored.
> If the keys do not start with domain + "." or "*.", it is probably because the user made a typo or mistake in the startup.properties. Instead of ignoring these keys, I propose that an error should be thrown.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)