You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/15 01:56:30 UTC

[GitHub] [iotdb] jt2594838 commented on a change in pull request #4825: [IOTDB-2392] Memory control of raft log in cluster

jt2594838 commented on a change in pull request #4825:
URL: https://github.com/apache/iotdb/pull/4825#discussion_r785254358



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/RaftMember.java
##########
@@ -2034,6 +2073,10 @@ private long appendEntries(
     }
 
     synchronized (logManager) {
+      if ((logManager.getCommitLogIndex() - logManager.getMaxHaveAppliedCommitIndex())
+          > config.getUnAppliedRaftLogNumForRejectThreshold()) {
+        return Response.RESPONSE_TOO_BUSY;
+      }

Review comment:
       Adding some wait time here may improve robustness.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org