[jira] [Commented] (CB-861) Header support for PhoneGap's FileTransfer (download)

["Tommy-Carlos Williams (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585288#comment-13585288 ] 

Tommy-Carlos Williams commented on CB-861:
------------------------------------------

OK. So after the discussion on the mailing list, I had a go at implementing FileTransfer.download headers for Android and iOS.

Tested downloads using basic authentication.

https://github.com/apache/cordova-js/pull/13
https://github.com/apache/cordova-ios/pull/20
https://github.com/apache/cordova-android/pull/21

One possible problem is the order of the arguments in the JS. I am worried that the changes might need at least to be ignored on the other platforms... 

It seemed strange to have the options argument be after the objectId arg in the actual exec call, but if it creates less impact on the other platforms, I am happy to make whatever changes deemed needed. Just let me know.
                
> Header support for PhoneGap's FileTransfer (download)
> -----------------------------------------------------
>
>                 Key: CB-861
>                 URL: https://issues.apache.org/jira/browse/CB-861
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android, CordovaJS
>    Affects Versions: 1.7.0
>            Reporter: Aurelien MERCIER
>            Assignee: Andrew Grieve
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira