You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/09 22:35:12 UTC
[GitHub] [beam] fernando-wizeline opened a new pull request, #23168: GA Migrations Java PreCommit PVR Flink Batch and Docker
fernando-wizeline opened a new pull request, #23168:
URL: https://github.com/apache/beam/pull/23168
As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:
Migrated workflow [job-precommit-java-pvr-flink-batch.yml](https://github.com/fernando-wizeline/beam/blob/gam-precommit-java-pvr-flink-batch-docker/.github/workflows/job-precommit-java-pvr-flink-batch.yml)
Migrated workflow [job-precommit-java-pvr-flink-docker.ymll](https://github.com/fernando-wizeline/beam/blob/gam-precommit-java-pvr-flink-batch-docker/.github/workflows/job-precommit-java-pvr-flink-docker.yml)
The migrated workflow was added to [CI.md](https://github.com/fernando-wizeline/beam/blob/gam-precommit-java-pvr-flink-batch-docker/CI.md)
DO NOT MERGE until the effort to use self-hosted runners is completed https://github.com/apache/beam/pull/22703
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a diff in pull request #23168: GA Migrations Java PreCommit PVR Flink Batch and Docker
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on code in PR #23168:
URL: https://github.com/apache/beam/pull/23168#discussion_r985981855
##########
.github/workflows/job-precommit-java-pvr-flink-batch.yml:
##########
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs PreCommit Java PVR Flink Batch scheduled on cron, on push to master and on pull request
+
+name: PreCommit Java PVR Flink Batch
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request_target:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/**',
+ 'runners/flink/**',
+ 'runners/java-fn-execution/**']
+permissions: read-all
+
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ precommit-java-pvr-flink-batch:
+ needs: set-properties
+ name: Run PreCommit Java PVR Flink Batch
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix: #JDK17 execution will fail due to new access policies applied to the core JDK libraries starting at JDK 16.
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ flink: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.FLINK_VERSIONS}}
+ exclude: #TODO: Remove exclude and retest once issue https://github.com/apache/beam/issues/23066 gets resolved.
+ - java: "11" #Creation of the DockerEnvironment fails with Java 11.
Review Comment:
No issue for this one yet, I will go ahead and create one.
##########
.github/workflows/job-precommit-java-pvr-flink-batch.yml:
##########
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs PreCommit Java PVR Flink Batch scheduled on cron, on push to master and on pull request
+
+name: PreCommit Java PVR Flink Batch
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request_target:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/**',
+ 'runners/flink/**',
+ 'runners/java-fn-execution/**']
+permissions: read-all
+
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ precommit-java-pvr-flink-batch:
+ needs: set-properties
+ name: Run PreCommit Java PVR Flink Batch
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix: #JDK17 execution will fail due to new access policies applied to the core JDK libraries starting at JDK 16.
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ flink: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.FLINK_VERSIONS}}
+ exclude: #TODO: Remove exclude and retest once issue https://github.com/apache/beam/issues/23066 gets resolved.
+ - java: "11" #Creation of the DockerEnvironment fails with Java 11.
Review Comment:
Deleted the previous comment. Just realized the problem with the creation of the DockerEnvironment is due to the ErrorProne library issues when compiled with JDK11. The issue tracking that is this one: https://github.com/apache/beam/issues/23066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23168: GA Migrations Java PreCommit PVR Flink Batch and Docker
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23168:
URL: https://github.com/apache/beam/pull/23168#discussion_r984989219
##########
.github/workflows/job-precommit-java-pvr-flink-batch.yml:
##########
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs PreCommit Java PVR Flink Batch scheduled on cron, on push to master and on pull request
+
+name: PreCommit Java PVR Flink Batch
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request_target:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/**',
+ 'runners/flink/**',
+ 'runners/java-fn-execution/**']
+permissions: read-all
+
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ precommit-java-pvr-flink-batch:
+ needs: set-properties
+ name: Run PreCommit Java PVR Flink Batch
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix: #JDK17 execution will fail due to new access policies applied to the core JDK libraries starting at JDK 16.
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ flink: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.FLINK_VERSIONS}}
+ exclude: #TODO: Remove exclude and retest once issue https://github.com/apache/beam/issues/23066 gets resolved.
+ - java: "11" #Creation of the DockerEnvironment fails with Java 11.
Review Comment:
Is there an issue tracking this?
##########
.github/workflows/job-precommit-java-pvr-flink-batch.yml:
##########
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs PreCommit Java PVR Flink Batch scheduled on cron, on push to master and on pull request
+
+name: PreCommit Java PVR Flink Batch
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request_target:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/**',
+ 'runners/flink/**',
+ 'runners/java-fn-execution/**']
+permissions: read-all
+
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ precommit-java-pvr-flink-batch:
+ needs: set-properties
+ name: Run PreCommit Java PVR Flink Batch
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix: #JDK17 execution will fail due to new access policies applied to the core JDK libraries starting at JDK 16.
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ flink: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.FLINK_VERSIONS}}
+ exclude: #TODO: Remove exclude and retest once issue https://github.com/apache/beam/issues/23066 gets resolved.
Review Comment:
Why does this impact GHA and not Jenkins?
##########
.github/workflows/job-precommit-java-pvr-flink-docker.yml:
##########
@@ -0,0 +1,87 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs PreCommit Java PVR Flink Docker scheduled on cron, on push to master and on pull request
+
+name: PreCommit Java PVR Flink Docker
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['main', 'release-*']
+ tags: 'v*'
+ pull_request_target:
+ branches: ['main', 'release-*']
+ tags: 'v*'
+ paths: ['sdks/java/core/src/test/java/org/apache/beam/sdk/**',
+ 'sdks/java/container/**',
+ 'sdks/java/harness/**',
+ 'runners/flink/**',
+ 'runners/java-fn-execution/**']
+permissions: read-all
+
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ precommit-java-pvr-flink-docker:
+ needs: set-properties
+ name: Run PreCommit Java PVR Flink Docker
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix: #JDK17 execution will fail due to new access policies applied to the core JDK libraries starting at JDK 16.
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ flink: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.FLINK_VERSIONS}}
+ exclude: #TODO: Remove exclude and retest once issue https://github.com/apache/beam/issues/23066 gets resolved.
+ - java: "11" #Creation of the DockerEnvironment fails with Java 11.
Review Comment:
Same questions as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a diff in pull request #23168: GA Migrations Java PreCommit PVR Flink Batch and Docker
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on code in PR #23168:
URL: https://github.com/apache/beam/pull/23168#discussion_r985981855
##########
.github/workflows/job-precommit-java-pvr-flink-batch.yml:
##########
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs PreCommit Java PVR Flink Batch scheduled on cron, on push to master and on pull request
+
+name: PreCommit Java PVR Flink Batch
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request_target:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/**',
+ 'runners/flink/**',
+ 'runners/java-fn-execution/**']
+permissions: read-all
+
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ precommit-java-pvr-flink-batch:
+ needs: set-properties
+ name: Run PreCommit Java PVR Flink Batch
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix: #JDK17 execution will fail due to new access policies applied to the core JDK libraries starting at JDK 16.
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ flink: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.FLINK_VERSIONS}}
+ exclude: #TODO: Remove exclude and retest once issue https://github.com/apache/beam/issues/23066 gets resolved.
+ - java: "11" #Creation of the DockerEnvironment fails with Java 11.
Review Comment:
No issue for this one yet, I will go ahead and create one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23168: GA Migrations Java PreCommit PVR Flink Batch and Docker
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23168:
URL: https://github.com/apache/beam/pull/23168#issuecomment-1353009138
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23168: GA Migrations Java PreCommit PVR Flink Batch and Docker
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23168:
URL: https://github.com/apache/beam/pull/23168#issuecomment-1340916487
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #23168: GA Migrations Java PreCommit PVR Flink Batch and Docker
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #23168: GA Migrations Java PreCommit PVR Flink Batch and Docker
URL: https://github.com/apache/beam/pull/23168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org