[GitHub] [beam] Abacn commented on a diff in pull request #25716: Stop emitting upon truncate in Java PeriodicSequence

["Abacn (via GitHub)" <gi...@apache.org>]

Abacn commented on code in PR #25716:
URL: https://github.com/apache/beam/pull/25716#discussion_r1124904736


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/PeriodicSequence.java:
##########
@@ -207,7 +213,7 @@ public ProcessContinuation processElement(
 
       boolean claimSuccess = true;
 
-      estimator.setWatermark(Instant.ofEpochMilli(restriction.getFrom()));
+      estimator.setWatermark(Instant.ofEpochMilli(nextOutput));

Review Comment:
   This change is made in accordance with Python implementation. Currently the watermark will be set back to the initial timestamp (which violates the monotonically increasing) though it will be set back in the while clause.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org