You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/04 00:33:45 UTC
[PR] [ISSUE #897] Report dashboard broker version [rocketmq-dashboard]
Aias00 opened a new pull request, #898:
URL: https://github.com/apache/rocketmq-dashboard/pull/898
### What
- Fix `RocketMQDashboardProvider` so cluster overview uses the first non-blank `brokerVersionDesc` from broker runtime stats.
- Add provider coverage proving the dashboard cluster version is populated instead of staying `unknown`.
### Why
The previous condition only assigned the broker version when the current value was already not `unknown`, so the initial `unknown` value was never replaced.
### Validation
- `JAVA_HOME=$(/usr/libexec/java_home -v 21) mvn -Dtest=RocketMQDashboardProviderTest test`
- `git diff --check`
Closes #897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #897] Report dashboard broker version [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #898: [ISSUE #897] Report dashboard broker version
URL: https://github.com/apache/rocketmq-dashboard/pull/898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #897] Report dashboard broker version [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #898:
URL: https://github.com/apache/rocketmq-dashboard/pull/898#issuecomment-5175485389
Superseded by consolidated PR #948, which contains this change and has passing checks. Closing this narrower PR to keep review focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org