You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/03 07:36:01 UTC

[GitHub] [incubator-dolphinscheduler] Technoboy- opened a new issue #1694: Refactor Alert module

Technoboy- opened a new issue #1694: Refactor Alert module
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1694
 
 
   Background
     Now, Alert module is a very simple function , just scanning db and triggering alert . As it's a single node, not distributed. 
   
   Suggestion
     As we discuss in the mail list , in this phase , we  will keep this module . So we need to do some refactor about this module.
     1.  Refactor EnterpriseWeChatUtils, using HttpUtils in common instead。
     2.  Using zk lock to keep Alert distributed 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] elonlo edited a comment on issue #1694: Refactor Alert module

Posted by GitBox <gi...@apache.org>.
elonlo edited a comment on issue #1694: Refactor Alert module
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1694#issuecomment-570601858
 
 
   My opinion is:
   
   Step 1: define the Manager interface, use JAVA SPI to decouple the sender logic, and support the registration of alarm plugins.
   
   Step 2: let the user call the API instead of scanning the DB regularly to trigger the alarm. Other server depends on the alert module to call the sender api. The specific implementation is to use a separate thread to send asynchronously.
   
   Step 3: get front-end alarm type list through api, and dynamically display alarm types.
   
   Step 4: Split off SMS and enterprise WeChat alert types into plug-ins

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- closed issue #1694: Refactor Alert module

Posted by GitBox <gi...@apache.org>.
Technoboy- closed issue #1694: Refactor Alert module
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1694
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] elonlo commented on issue #1694: Refactor Alert module

Posted by GitBox <gi...@apache.org>.
elonlo commented on issue #1694: Refactor Alert module
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1694#issuecomment-570601858
 
 
   My opinion is:
   
   Step 1: define the Manager interface, use JAVA SPI to decouple the sender logic, and support the registration of alarm plugins.
   
   Step 2: let the user call the API instead of scanning the DB regularly to trigger the alarm. Other server depends on the alert module to call the sender api. The specific implementation is to use a separate thread to send asynchronously.
   
   Step 3: get front-end alarm type list through api, and dynamically display alarm types.
   
   Part 4: Split off SMS and enterprise WeChat alert types into plug-ins

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services