You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/20 09:40:22 UTC
[GitHub] [spark] sarutak opened a new pull request #31261: [SPARK-34005][CORE][3.1] Update peak memory metrics for each Executor on task end
sarutak opened a new pull request #31261:
URL: https://github.com/apache/spark/pull/31261
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR makes `AppStatusListener` update the peak memory metrics for each Executor on task end like other peak memory metrics (e.g, stage, executors in a stage).
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
When `AppStatusListener#onExecutorMetricsUpdate` is called, peak memory metrics for Executors, stages and executors in a stage are updated but currently, the metrics only for Executors are not updated on task end.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Executor peak memory metrics is updated more accurately.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
After I run a job with `local-cluster[1,1,1024]` and visited `/api/v1/<appid>/executors`, I confirmed `peakExecutorMemory` metrics is shown for an Executor even though the life time of each job is very short .
I also modify the json files for `HistoryServerSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31261: [SPARK-34005][CORE][3.1] Update peak memory metrics for each Executor on task end
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31261:
URL: https://github.com/apache/spark/pull/31261#issuecomment-763557495
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #31261: [SPARK-34005][CORE][3.1] Update peak memory metrics for each Executor on task end
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #31261:
URL: https://github.com/apache/spark/pull/31261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31261: [SPARK-34005][CORE][3.1] Update peak memory metrics for each Executor on task end
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31261:
URL: https://github.com/apache/spark/pull/31261#issuecomment-763473850
cc: @HyukjinKwon @dongjoon-hyun @gengliangwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31261: [SPARK-34005][CORE][3.1] Update peak memory metrics for each Executor on task end
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31261:
URL: https://github.com/apache/spark/pull/31261#issuecomment-763522611
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38849/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31261: [SPARK-34005][CORE][3.1] Update peak memory metrics for each Executor on task end
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31261:
URL: https://github.com/apache/spark/pull/31261#issuecomment-763553724
**[Test build #134263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134263/testReport)** for PR 31261 at commit [`4d721f2`](https://github.com/apache/spark/commit/4d721f2ded0e202938e7fe5b545a56beeda8ff1d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31261: [SPARK-34005][CORE][3.1] Update peak memory metrics for each Executor on task end
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31261:
URL: https://github.com/apache/spark/pull/31261#issuecomment-763557495
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31261: [SPARK-34005][CORE][3.1] Update peak memory metrics for each Executor on task end
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31261:
URL: https://github.com/apache/spark/pull/31261#issuecomment-763490416
**[Test build #134263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134263/testReport)** for PR 31261 at commit [`4d721f2`](https://github.com/apache/spark/commit/4d721f2ded0e202938e7fe5b545a56beeda8ff1d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31261: [SPARK-34005][CORE][3.1] Update peak memory metrics for each Executor on task end
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31261:
URL: https://github.com/apache/spark/pull/31261#issuecomment-763490416
**[Test build #134263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134263/testReport)** for PR 31261 at commit [`4d721f2`](https://github.com/apache/spark/commit/4d721f2ded0e202938e7fe5b545a56beeda8ff1d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #31261: [SPARK-34005][CORE][3.1] Update peak memory metrics for each Executor on task end
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #31261:
URL: https://github.com/apache/spark/pull/31261#issuecomment-763550598
Thanks, merging to branch-3.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31261: [SPARK-34005][CORE][3.1] Update peak memory metrics for each Executor on task end
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31261:
URL: https://github.com/apache/spark/pull/31261#issuecomment-763549685
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38849/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org