[jira] [Work logged] (HIVE-24874) Worker performance metric

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-24874?focusedWorklogId=566824&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566824 ]

ASF GitHub Bot logged work on HIVE-24874:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Mar/21 09:36
            Start Date: 16/Mar/21 09:36
    Worklog Time Spent: 10m 
      Work Description: pvargacl commented on a change in pull request #2062:
URL: https://github.com/apache/hive/pull/2062#discussion_r595001156



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -97,12 +99,14 @@ public static String hostname() {
   public void run() {
     LOG.info("Starting Worker thread");
     boolean computeStats = conf.getBoolVar(HiveConf.ConfVars.HIVE_MR_COMPACTOR_GATHER_STATS);
+    boolean metricsEnabled = conf.getBoolVar(HiveConf.ConfVars.HIVE_SERVER2_METRICS_ENABLED);

Review comment:
       I didn't see anywhere in HS2 to check this property before using perflogger, the metricsfactory will be disabled globally if this is not enabled. You can remove it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 566824)
    Remaining Estimate: 0h
            Time Spent: 10m

> Worker performance metric
> -------------------------
>
>                 Key: HIVE-24874
>                 URL: https://issues.apache.org/jira/browse/HIVE-24874
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Denys Kuzmenko
>            Assignee: Denys Kuzmenko
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Wrap Compaction Worker with PerformanceLogger.
> Major and Minor compactions should be measured to separate metrics.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)