You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/03 16:47:55 UTC

[GitHub] [incubator-nuttx] juniskane opened a new pull request #2210: arch/arm/src/stm32/stm32_adc.c: do not allow negative ref count

juniskane opened a new pull request #2210:
URL: https://github.com/apache/incubator-nuttx/pull/2210


   ## Summary
   When HAVE_HSI_CONTROL, adc_reset_hsi_disable() calls adc_reset()
   followed by adc_shutdown() and this combination is called before
   adc_setup() by upper level ADC driver. Without this patch,
   priv->initialized wraps from 0 to 255 in this case.
   
   ## Impact
   read() from /dev/adc0 was hanging forever on STM32L1 that used HSI as ADC dedicated clock.
   
   ## Testing
   Tested with a proprietary STM32L1 board.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #2210: arch/arm/src/stm32/stm32_adc.c: do not allow negative ref count

Posted by GitBox <gi...@apache.org>.

acassis merged pull request #2210:
URL: https://github.com/apache/incubator-nuttx/pull/2210


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #2210: arch/arm/src/stm32/stm32_adc.c: do not allow negative ref count

Posted by GitBox <gi...@apache.org>.

acassis commented on pull request #2210:
URL: https://github.com/apache/incubator-nuttx/pull/2210#issuecomment-721328885


   Good finding, thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org