You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by khawkins <gi...@git.apache.org> on 2014/10/05 05:19:03 UTC
[GitHub] cordova-ios pull request: Creating a customizable user agent for i...
GitHub user khawkins opened a pull request:
https://github.com/apache/cordova-ios/pull/112
Creating a customizable user agent for iOS
Fix for [CB-2520](https://issues.apache.org/jira/browse/CB-2520). Presumably, we'd eventually want a more user-exposed entry path to this. But this work should be a good first step to that.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khawkins/cordova-ios CB-2520
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #112
----
commit 36476a8c0dd6f1ae07e519a3752ececc5228f3df
Author: Kevin Hawkins <kh...@salesforce.com>
Date: 2014-10-05T02:45:54Z
Creating a customizable user agent
commit 661f87d404cd17c43515cc259a69a8c111750313
Author: Kevin Hawkins <kh...@salesforce.com>
Date: 2014-10-05T03:16:52Z
Making baseUserAgent an instance property
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Creating a customizable user agent for i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Creating a customizable user agent for i...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58256220
Hi @khawkins the cordova.js stuff should actually be in the cordova-js repo: http://github.com/apache/cordova-js
The file you see here is dynamically generated from that repo, and included when a new release is tagged (or when significant changes in cordova-js occurs)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Creating a customizable user agent for i...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58958943
Ah, sorry. However as you can see in this pull request, according to Github your PR has merge conflicts that need to be re-based.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Creating a customizable user agent for i...
Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58958989
So it does! I'll rebase now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Creating a customizable user agent for i...
Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58957206
Are we not going to merge it? Sorry, it's been a while and I don't remember the exact order of things for getting changes into the repo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Creating a customizable user agent for i...
Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58263722
@shazron Okay, I think I got everything worked out wrt cordova-js, and reverting here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Creating a customizable user agent for i...
Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58958702
They're compound changes. There are changes in the JS *and* the native layer. I've reverted the JS changes here, but the native code changes remain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Creating a customizable user agent for i...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58957912
I meant that you've already submitted a PR to cordova-js (https://github.com/apache/cordova-js/pull/84), this one is obsolete because it is not the right repo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Creating a customizable user agent for i...
Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/112#discussion_r18433084
--- Diff: CordovaLib/cordova.js ---
@@ -918,15 +918,8 @@ function convertMessageToArgsNativeToJs(message) {
}
function iOSExec() {
- // Use XHR for iOS 5 to work around a bug in -webkit-scroll.
--- End diff --
Since iOS 6 is now the minimum, took this check out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Creating a customizable user agent for i...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58952165
Thanks Kevin, can you close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Creating a customizable user agent for i...
Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58258046
Ah, thanks @shazron , I'll clear it here, and submit that one over there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Creating a customizable user agent for i...
Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/112#discussion_r18433085
--- Diff: CordovaLib/cordova.js ---
@@ -1017,7 +1010,7 @@ function pokeNativeViaXhr() {
// Add a timestamp to the query param to prevent caching.
execXhr.open('HEAD', "/!gap_exec?" + (+new Date()), true);
if (!vcHeaderValue) {
- vcHeaderValue = /.*\((.*)\)/.exec(navigator.userAgent)[1];
+ vcHeaderValue = /.*\((.*)\)$/.exec(navigator.userAgent)[1];
--- End diff --
In the wake of configurable user agents, this is more deterministic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org