You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Marcus Sorensen <sh...@gmail.com> on 2012/09/20 18:43:38 UTC
Review Request: KVM fails to copy authorized_keys to system vm now that iso
is not mounted
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7194/
-----------------------------------------------------------
Review request for cloudstack and edison su.
Description
-------
Recent change was made to ignore the systemvm.iso in KVM and only mount the root and patch disks. As a result, the /etc/init.d/cloud-early-config script no longer attempts to copy the authorized_keys file, since the copy command is in an if statement that looks for the cdrom. This patch copies the authorized_keys for kvm.
Diffs
-----
patches/systemvm/debian/config/etc/init.d/cloud-early-config ca97d29
Diff: https://reviews.apache.org/r/7194/diff/
Testing
-------
tested against latest 4.0
Thanks,
Marcus Sorensen
Re: Review Request: KVM fails to copy authorized_keys to system vm now that
iso is not mounted
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7194/#review11741
-----------------------------------------------------------
Ship it!
Ship It!
- edison su
On Sept. 20, 2012, 5:55 p.m., Marcus Sorensen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7194/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2012, 5:55 p.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Description
> -------
>
> Recent change was made to ignore the systemvm.iso in KVM and only mount the root and patch disks. As a result, the /etc/init.d/cloud-early-config script no longer attempts to copy the authorized_keys file, since the copy command is in an if statement that looks for the cdrom. This patch copies the authorized_keys for kvm.
>
> Update: the system vm iso is the bigger issue, and I'm submitting a separate fix for that, but I think it makes sense to not depend on the cdrom being mounted to copy the /var/cache authorized keys since it's a function of the patch disk, so this patch still applies.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/etc/init.d/cloud-early-config ca97d29
>
> Diff: https://reviews.apache.org/r/7194/diff/
>
>
> Testing
> -------
>
> tested against latest 4.0
>
>
> Thanks,
>
> Marcus Sorensen
>
>
Re: Review Request: KVM fails to copy authorized_keys to system vm now that
iso is not mounted
Posted by Marcus Sorensen <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7194/
-----------------------------------------------------------
(Updated Sept. 20, 2012, 5:55 p.m.)
Review request for cloudstack and edison su.
Changes
-------
updated description
Description (updated)
-------
Recent change was made to ignore the systemvm.iso in KVM and only mount the root and patch disks. As a result, the /etc/init.d/cloud-early-config script no longer attempts to copy the authorized_keys file, since the copy command is in an if statement that looks for the cdrom. This patch copies the authorized_keys for kvm.
Update: the system vm iso is the bigger issue, and I'm submitting a separate fix for that, but I think it makes sense to not depend on the cdrom being mounted to copy the /var/cache authorized keys since it's a function of the patch disk, so this patch still applies.
Diffs
-----
patches/systemvm/debian/config/etc/init.d/cloud-early-config ca97d29
Diff: https://reviews.apache.org/r/7194/diff/
Testing
-------
tested against latest 4.0
Thanks,
Marcus Sorensen