[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4125: [KYUUBI #4112] [Authz] Check privilege for output table of InsertIntoHadoopFsRelationCommand

[GitBox <gi...@apache.org>]

bowenliang123 commented on code in PR #4125:
URL: https://github.com/apache/kyuubi/pull/4125#discussion_r1064241250


##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/gen/TableCommands.scala:
##########
@@ -518,6 +518,19 @@ object TableCommands {
     TableCommandSpec(cmd, Nil, queryDescs = Seq(queryDesc))
   }
 
+  val InsertIntoHadoopFsRelationCommand = {
+    val cmd = "org.apache.spark.sql.execution.datasources.InsertIntoHadoopFsRelationCommand"
+    val actionTypeDesc = ActionTypeDesc(null, null, Some("UPDATE"))

Review Comment:
   OK, will add a SaveModeActionTypeExtractor to determine ActionType `INSERT` or `INSERT_OVERWRITE` in our case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org