You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Harsh J (Created) (JIRA)" <ji...@apache.org> on 2012/01/09 05:59:39 UTC
[jira] [Created] (HBASE-5151) Rename "hbase.skip.errors" in HRegion
as it is too general-sounding.
Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
--------------------------------------------------------------------
Key: HBASE-5151
URL: https://issues.apache.org/jira/browse/HBASE-5151
Project: HBase
Issue Type: Sub-task
Components: documentation
Affects Versions: 0.94.0
Reporter: Harsh J
We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5151) Rename "hbase.skip.errors" in
HRegion as it is too general-sounding.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412686#comment-13412686 ]
Harsh J commented on HBASE-5151:
--------------------------------
bq. This is another reason we need versioning in patch filenames so that such mistakes can be more easily avoided.
Understood Ted. When posting patches over HBASE in future, I'll make sure to number them every revision. Thanks! :)
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.96.0
>
> Attachments: HBASE-5151.amend.patch, HBASE-5151.amend.wrapped.patch, HBASE-5151.patch, HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5151) Rename "hbase.skip.errors" in HRegion
as it is too general-sounding.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5151:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch Harsh.
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.96.0
>
> Attachments: HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5151) Rename "hbase.skip.errors" in
HRegion as it is too general-sounding.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411570#comment-13411570 ]
Zhihong Ted Yu commented on HBASE-5151:
---------------------------------------
In trunk build 3118:
{code}
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile (default-compile) on project hbase-server: Compilation failure: Compilation failure:
[ERROR] /home/jenkins/jenkins-slave/workspace/HBase-TRUNK/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:[2854,63] ')' expected
[ERROR]
[ERROR] /home/jenkins/jenkins-slave/workspace/HBase-TRUNK/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:[2855,19] not a statement
[ERROR]
[ERROR] /home/jenkins/jenkins-slave/workspace/HBase-TRUNK/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:[2855,22] ';' expected
[ERROR]
[ERROR] /home/jenkins/jenkins-slave/workspace/HBase-TRUNK/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:[2855,24] not a statement
[ERROR]
[ERROR] /home/jenkins/jenkins-slave/workspace/HBase-TRUNK/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:[2855,25] ';' expected
{code}
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.96.0
>
> Attachments: HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5151) Rename "hbase.skip.errors" in
HRegion as it is too general-sounding.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412056#comment-13412056 ]
Zhihong Ted Yu commented on HBASE-5151:
---------------------------------------
It turns out that the first patch was syntactically correct.
Harsh added something in patch v2 which wouldn't pass compilation.
Currently Hadoop QA wouldn't post back if there is compilation error.
However, Stack wasn't aware of the above and integrated patch v2.
This is another reason we need versioning in patch filenames so that such mistakes can be more easily avoided.
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.96.0
>
> Attachments: HBASE-5151.amend.patch, HBASE-5151.amend.wrapped.patch, HBASE-5151.patch, HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5151) Rename "hbase.skip.errors" in
HRegion as it is too general-sounding.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411584#comment-13411584 ]
Zhihong Ted Yu commented on HBASE-5151:
---------------------------------------
@Harsh:
In the future, please version patches with a number.
Now we have three attachments with the same name.
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.96.0
>
> Attachments: HBASE-5151.amend.patch, HBASE-5151.patch, HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5151) Rename "hbase.skip.errors" in
HRegion as it is too general-sounding.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411608#comment-13411608 ]
Zhihong Ted Yu commented on HBASE-5151:
---------------------------------------
The line being corrected in addendum is too long.
Please attach another addendum which wraps that line.
Thanks
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.96.0
>
> Attachments: HBASE-5151.amend.patch, HBASE-5151.patch, HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5151) Rename "hbase.skip.errors" in
HRegion as it is too general-sounding.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412043#comment-13412043 ]
Hudson commented on HBASE-5151:
-------------------------------
Integrated in HBase-TRUNK #3119 (See [https://builds.apache.org/job/HBase-TRUNK/3119/])
HBASE-5151 Rename hbase.skip.errors in HRegion as it is too general-sounding (Revision 1360384)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.96.0
>
> Attachments: HBASE-5151.amend.patch, HBASE-5151.amend.wrapped.patch, HBASE-5151.patch, HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5151) Rename "hbase.skip.errors" in
HRegion as it is too general-sounding.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411589#comment-13411589 ]
Harsh J commented on HBASE-5151:
--------------------------------
Sure, will do. I thought it was practice to rely on JIRA's coloring of the older versions of the same name as gray and the newer as blue. Thats what we've followed on HADOOP mostly, so its become a habit, sorry.
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.96.0
>
> Attachments: HBASE-5151.amend.patch, HBASE-5151.patch, HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5151) Rename "hbase.skip.errors" in HRegion
as it is too general-sounding.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HBASE-5151:
---------------------------
Assignee: Harsh J
Status: Patch Available (was: Open)
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5151) Rename "hbase.skip.errors" in HRegion
as it is too general-sounding.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HBASE-5151:
---------------------------
Attachment: HBASE-5151.patch
HBASE-5151.amend.patch
GAH, sorry guys! Amendment attached (.amend.patch, carries just fix of "+", delta).
Also attached a completely whole proper diff - whichever you may need to apply (revert and apply vs. amend apply).
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.96.0
>
> Attachments: HBASE-5151.amend.patch, HBASE-5151.patch, HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5151) Rename "hbase.skip.errors" in HRegion
as it is too general-sounding.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HBASE-5151:
---------------------------
Attachment: HBASE-5151.amend.wrapped.patch
Here it is.
Will be more careful in future, apologies.
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.96.0
>
> Attachments: HBASE-5151.amend.patch, HBASE-5151.amend.wrapped.patch, HBASE-5151.patch, HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5151) Rename "hbase.skip.errors" in HRegion
as it is too general-sounding.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HBASE-5151:
---------------------------
Attachment: HBASE-5151.patch
This patch deprecates "hbase.skip.errors" in favor of the new style config mentioned above.
Ideally I'd have used Configuration.addDeprecatedKeys but thats sadly available only in Hadoop 2.x onwards. I think it will do HBase a good deal someday in future to shed off multiple Hadoop deps to a single, rolling one alone. That day, we can have proper deprecation features in HBaseConfiguration without duplicating code or hacking around, or even having extra code like this patch required.
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Attachments: HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5151) Rename "hbase.skip.errors" in
HRegion as it is too general-sounding.
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185966#comment-13185966 ]
stack commented on HBASE-5151:
------------------------------
+1
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5151) Rename "hbase.skip.errors" in
HRegion as it is too general-sounding.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409227#comment-13409227 ]
Hadoop QA commented on HBASE-5151:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12535626/HBASE-5151.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that doesn't require tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestAssignmentManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2352//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2352//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2352//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2352//console
This message is automatically generated.
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5151) Rename "hbase.skip.errors" in
HRegion as it is too general-sounding.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409551#comment-13409551 ]
stack commented on HBASE-5151:
------------------------------
@Harsh Patch looks good. Does the above test fail for you?
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5151) Rename "hbase.skip.errors" in HRegion
as it is too general-sounding.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HBASE-5151:
---------------------------
Attachment: HBASE-5151.patch
It passes for me:
{code}
T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.master.TestAssignmentManager
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.817 sec
Results :
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
{code}
However I forgot to fix the additional logger string reference to the old prop so I did that now in this new patch. Sorry!
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5151) Rename "hbase.skip.errors" in
HRegion as it is too general-sounding.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411558#comment-13411558 ]
Hudson commented on HBASE-5151:
-------------------------------
Integrated in HBase-TRUNK #3118 (See [https://builds.apache.org/job/HBase-TRUNK/3118/])
HBASE-5151 Rename hbase.skip.errors in HRegion as it is too general-sounding (Revision 1360172)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.96.0
>
> Attachments: HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5151) Rename "hbase.skip.errors" in
HRegion as it is too general-sounding.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411966#comment-13411966 ]
stack commented on HBASE-5151:
------------------------------
I applied the amendment. Thanks Harsh.
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.96.0
>
> Attachments: HBASE-5151.amend.patch, HBASE-5151.amend.wrapped.patch, HBASE-5151.patch, HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5151) Rename "hbase.skip.errors" in
HRegion as it is too general-sounding.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411959#comment-13411959 ]
stack commented on HBASE-5151:
------------------------------
@Harsh No need to apologize. Thanks for fast turn around. Applying the amendment.
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
> Key: HBASE-5151
> URL: https://issues.apache.org/jira/browse/HBASE-5151
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.96.0
>
> Attachments: HBASE-5151.amend.patch, HBASE-5151.amend.wrapped.patch, HBASE-5151.patch, HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping errors when replaying edits. It should probably be something more like "hbase.hregion.edits.replay.skip.errors" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira