You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by GitBox <gi...@apache.org> on 2023/01/02 21:18:08 UTC
[GitHub] [opennlp] rzo1 opened a new pull request, #481: OPENNLP-1340 - Get the probability for a sequence without copying the probabilities
rzo1 opened a new pull request, #481:
URL: https://github.com/apache/opennlp/pull/481
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] mawiesne commented on a diff in pull request #481: OPENNLP-1340 - Get the probability for a sequence without copying the probabilities
Posted by GitBox <gi...@apache.org>.
mawiesne commented on code in PR #481:
URL: https://github.com/apache/opennlp/pull/481#discussion_r1060558324
##########
opennlp-tools/src/main/java/opennlp/tools/util/Sequence.java:
##########
@@ -122,7 +122,32 @@ public void add(String outcome, double p) {
* @return Retrieves a list of outcomes for this {@link Sequence}.
*/
public List<String> getOutcomes() {
- return outcomes;
+ return List.copyOf(outcomes);
+ }
+
+ /**
+ * @return Retrieves the size of the outcomes for this {@link Sequence}.
+ */
+ public int getSize() {
+ return outcomes.size();
+ }
+
+ /**
+ * @param index must be greater than or equal to zero and must not exceed {@link Sequence#getSize()}.
Review Comment:
Should read: ".. must be less than {@link Sequence#getSize()}"
##########
opennlp-tools/src/main/java/opennlp/tools/util/Sequence.java:
##########
@@ -122,7 +122,32 @@ public void add(String outcome, double p) {
* @return Retrieves a list of outcomes for this {@link Sequence}.
*/
public List<String> getOutcomes() {
- return outcomes;
+ return List.copyOf(outcomes);
+ }
+
+ /**
+ * @return Retrieves the size of the outcomes for this {@link Sequence}.
+ */
+ public int getSize() {
+ return outcomes.size();
+ }
+
+ /**
+ * @param index must be greater than or equal to zero and must not exceed {@link Sequence#getSize()}.
+ * @return the outcome at the specified index.
+ * @throws IndexOutOfBoundsException thrown if the given index is out of range.
+ */
+ public String getOutcome(int index) {
+ return outcomes.get(index);
+ }
+
+ /**
+ * @param index must be greater than or equal to zero and must not exceed {@link Sequence#getSize()}.
Review Comment:
Should read: ".. must be less than {@link Sequence#getSize()}"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] jzonthemtn merged pull request #481: OPENNLP-1340 - Get the probability for a sequence without copying the probabilities
Posted by GitBox <gi...@apache.org>.
jzonthemtn merged PR #481:
URL: https://github.com/apache/opennlp/pull/481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] rzo1 commented on a diff in pull request #481: OPENNLP-1340 - Get the probability for a sequence without copying the probabilities
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #481:
URL: https://github.com/apache/opennlp/pull/481#discussion_r1060319598
##########
opennlp-tools/src/main/java/opennlp/tools/util/Sequence.java:
##########
@@ -122,7 +122,32 @@ public void add(String outcome, double p) {
* @return Retrieves a list of outcomes for this {@link Sequence}.
*/
public List<String> getOutcomes() {
- return outcomes;
+ return List.copyOf(outcomes);
+ }
+
+ /**
+ * @return Retrieves the size of the outcomes for this {@link Sequence}.
+ */
+ public int getSize() {
+ return outcomes.size();
+ }
+
+ /**
+ * @param index must be greater than zero and must not exceed {@link Sequence#getSize()}.
Review Comment:
Reading it after the night, it should better read: "must be greater or equal to zero". 0 is an allowed value here. Will fix later.
##########
opennlp-tools/src/main/java/opennlp/tools/util/Sequence.java:
##########
@@ -122,7 +122,32 @@ public void add(String outcome, double p) {
* @return Retrieves a list of outcomes for this {@link Sequence}.
*/
public List<String> getOutcomes() {
- return outcomes;
+ return List.copyOf(outcomes);
+ }
+
+ /**
+ * @return Retrieves the size of the outcomes for this {@link Sequence}.
+ */
+ public int getSize() {
+ return outcomes.size();
+ }
+
+ /**
+ * @param index must be greater than zero and must not exceed {@link Sequence#getSize()}.
+ * @return the outcome at the specified index.
+ * @throws IndexOutOfBoundsException thrown if the given index is out of range.
+ */
+ public String getOutcome(int index) {
+ return outcomes.get(index);
+ }
+
+ /**
+ * @param index must be greater than zero and must not exceed {@link Sequence#getSize()}.
Review Comment:
Dito
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org