You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/05 17:20:00 UTC
[jira] [Commented] (THRIFT-4494) Increase Java Socket Buffer Size
[ https://issues.apache.org/jira/browse/THRIFT-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640104#comment-16640104 ]
ASF GitHub Bot commented on THRIFT-4494:
----------------------------------------
nrg4878 opened a new pull request #1608: THRIFT-4494: Increase Java Socket Buffer Size (BELUGA BEHR)
URL: https://github.com/apache/thrift/pull/1608
@jeking3 Could you please review this as well. Thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Increase Java Socket Buffer Size
> --------------------------------
>
> Key: THRIFT-4494
> URL: https://issues.apache.org/jira/browse/THRIFT-4494
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.11.0
> Reporter: BELUGA BEHR
> Priority: Minor
> Attachments: THRIFT-4494.1.patch
>
>
> {code:title=TSocket.java}
> if (isOpen()) {
> try {
> inputStream_ = new BufferedInputStream(socket_.getInputStream(), 1024);
> outputStream_ = new BufferedOutputStream(socket_.getOutputStream(), 1024);
> } catch (IOException iox) {
> close();
> throw new TTransportException(TTransportException.NOT_OPEN, iox);
> }
> }
> {code}
> The 1024 buffer size is pretty narrow, especially for modern servers with TCP/IP send and receive buffers ranging from 16K to 64K. Please remove these hard coded values and rely on the underlying JVM default buffer sizes: 8Kib on most implementations.
> https://github.com/apache/thrift/blob/19baeefd8c38d62085891d7956349601f79448b3/lib/java/src/org/apache/thrift/transport/TSocket.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)