You are viewing a plain text version of this content. The canonical link for it is here.

Posted to droids-dev@incubator.apache.org by "Eugen Paraschiv (JIRA)" <ji...@apache.org> on 2011/02/21 20:16:38 UTC

[jira] Resolved: (DROIDS-125) SaveHandler - clean up

     [ https://issues.apache.org/jira/browse/DROIDS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eugen Paraschiv resolved DROIDS-125.
------------------------------------

    Resolution: Fixed

> SaveHandler - clean up
> ----------------------
>
>                 Key: DROIDS-125
>                 URL: https://issues.apache.org/jira/browse/DROIDS-125
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.0.1
>            Reporter: Eugen Paraschiv
>             Fix For: 0.0.1
>
>         Attachments: DROIDS-125_v1.patch
>
>
> There are a few things that should be cleaned up in SaveHandler: 
> - should remove the default values for class members (unnecessary)
> - should remove the caught and rethrown IOException (unnecessary)
> - should separate the responsibility of calculating the file path from the actual writing of the output
> - could inject the outputDir the constructor

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira