[jira] [Commented] (MSHARED-1031) PatternIncludesArtifactFilter#include( Artifact )

["Michael Osipov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHARED-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553082#comment-17553082 ] 

Michael Osipov commented on MSHARED-1031:
-----------------------------------------

I think this has now been fixed on master.

> PatternIncludesArtifactFilter#include( Artifact ) 
> --------------------------------------------------
>
>                 Key: MSHARED-1031
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1031
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-common-artifact-filters
>    Affects Versions: maven-common-artifact-filters-3.2.0
>            Reporter: Tibor Digana
>            Priority: Major
>
> In principle the call looks like this:
> {noformat}
> new PatternIncludesArtifactFilter("org.surefire.dependency:dependent-artifact2:*:*:tests-jdk15").include("org.surefire.dependency:dependent-artifact2:jar:tests-jdk15:1.0" with scope tests)
> {noformat}
> The problem is that PatternIncludesArtifactFilter uses the comparison via {{!=}} on {{char[]}}, see more specifically {{tokens[3] != ANY}}, and next issue is that PatternIncludesArtifactFilter expects wildcard on classifier which is not very useful, see the comment {{we only accept 5 tokens if the classifier = '*'}}.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)