You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/08/28 01:52:08 UTC

Review Request 37863: Fixed user cgroup failing test on centos 7.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37863/
-----------------------------------------------------------

Review request for mesos, Jie Yu, Marco Massenzio, and Vinod Kone.


Bugs: MESOS-3294
    https://issues.apache.org/jira/browse/MESOS-3294


Repository: mesos


Description
-------

Fixed user cgroup failing test on centos 7.

This is due to a bug that exists in CentOS 7 where the cgroup is named differently under /sys/fs/cgroup.


Diffs
-----

  src/tests/containerizer/isolator_tests.cpp 2755d06b0a097f46bc75fb9b830bc131f7a2255c 

Diff: https://reviews.apache.org/r/37863/diff/


Testing
-------

make check on CentOS7


Thanks,

Timothy Chen

Re: Review Request 37863: Fixed user cgroup failing test on centos 7.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37863/
-----------------------------------------------------------

(Updated Aug. 28, 2015, 12:05 a.m.)


Review request for mesos, Jie Yu, Marco Massenzio, and Vinod Kone.


Bugs: MESOS-3294
    https://issues.apache.org/jira/browse/MESOS-3294


Repository: mesos


Description
-------

Fixed user cgroup failing test on centos 7.

This is due to a bug that exists in CentOS 7 where the cgroup is named differently under /sys/fs/cgroup.


Diffs (updated)
-----

  src/tests/containerizer/isolator_tests.cpp 2755d06b0a097f46bc75fb9b830bc131f7a2255c 

Diff: https://reviews.apache.org/r/37863/diff/


Testing
-------

make check on CentOS7


Thanks,

Timothy Chen

Re: Review Request 37863: Fixed user cgroup failing test on centos 7.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37863/#review96797
-----------------------------------------------------------

Ship it!



src/tests/containerizer/isolator_tests.cpp (lines 1268 - 1272)
<https://reviews.apache.org/r/37863/#comment152448>

    I would do the following so that it's more easy to understand.
    ```
    if (!os::exists(...) &&
        strings::startsWith(...)) {
      // swap as you did
    }
    ```



src/tests/containerizer/isolator_tests.cpp (line 1279)
<https://reviews.apache.org/r/37863/#comment152449>

    Please remove this.


- Jie Yu


On Aug. 27, 2015, 11:52 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37863/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 11:52 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Marco Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3294
>     https://issues.apache.org/jira/browse/MESOS-3294
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed user cgroup failing test on centos 7.
> 
> This is due to a bug that exists in CentOS 7 where the cgroup is named differently under /sys/fs/cgroup.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/isolator_tests.cpp 2755d06b0a097f46bc75fb9b830bc131f7a2255c 
> 
> Diff: https://reviews.apache.org/r/37863/diff/
> 
> 
> Testing
> -------
> 
> make check on CentOS7
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>