You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by cl...@apache.org on 2015/05/22 01:45:33 UTC

[01/10] activemq-artemis git commit: Fix integration-tests: Arrays.toString(..) and ignored AssertionError

Repository: activemq-artemis
Updated Branches:
  refs/heads/master 27cbc92a9 -> 30416db00


Fix integration-tests: Arrays.toString(..) and ignored AssertionError


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/7ca05753
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/7ca05753
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/7ca05753

Branch: refs/heads/master
Commit: 7ca05753bfe227d4e2c99f932ee63c88d4df8e62
Parents: 27dd5c2
Author: Thiago Kronig <ca...@uolinc.com>
Authored: Fri May 8 21:06:49 2015 -0300
Committer: Clebert Suconic <cl...@apache.org>
Committed: Thu May 21 19:45:01 2015 -0400

----------------------------------------------------------------------
 .../artemis/tests/integration/client/LargeMessageTest.java      | 3 ++-
 .../artemis/tests/integration/discovery/DiscoveryTest.java      | 2 +-
 .../tests/integration/management/ManagementHelperTest.java      | 5 +++--
 3 files changed, 6 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7ca05753/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/LargeMessageTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/LargeMessageTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/LargeMessageTest.java
index 02fd208..65bdea8 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/LargeMessageTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/LargeMessageTest.java
@@ -235,8 +235,9 @@ public class LargeMessageTest extends LargeMessageTestBase
          msg1.getBodyBuffer().readByte();
          Assert.fail("Exception was expected");
       }
-      catch (Throwable ignored)
+      catch (final Exception ignored)
       {
+         // empty on purpose
       }
 
       session.close();

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7ca05753/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/discovery/DiscoveryTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/discovery/DiscoveryTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/discovery/DiscoveryTest.java
index 82037a1..84a03f6 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/discovery/DiscoveryTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/discovery/DiscoveryTest.java
@@ -391,7 +391,7 @@ public class DiscoveryTest extends DiscoveryBaseTest
 
          byte[] btreceived = client.receiveBroadcast(5, TimeUnit.SECONDS);
 
-         System.out.println("BTReceived = " + btreceived);
+         System.out.println("BTReceived = " + Arrays.toString(btreceived));
 
          assertNotNull(btreceived);
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7ca05753/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ManagementHelperTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ManagementHelperTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ManagementHelperTest.java
index dbf5266..d6c2da7 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ManagementHelperTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ManagementHelperTest.java
@@ -16,6 +16,7 @@
  */
 package org.apache.activemq.artemis.tests.integration.management;
 
+import java.util.Arrays;
 import java.util.HashMap;
 import java.util.Map;
 
@@ -193,12 +194,12 @@ public class ManagementHelperTest extends Assert
       String key1 = RandomUtil.randomString();
       String[] val1 = new String[]{"a", "b", "c"};
 
-      ManagementHelperTest.log.info("val1 type is " + val1);
+      ManagementHelperTest.log.info("val1 type is " + Arrays.toString(val1));
 
       String key2 = RandomUtil.randomString();
       Integer[] val2 = new Integer[]{1, 2, 3, 4, 5};
 
-      ManagementHelperTest.log.info("val2 type is " + val2);
+      ManagementHelperTest.log.info("val2 type is " + Arrays.toString(val2));
 
       map.put(key1, val1);
       map.put(key2, val2);


[09/10] activemq-artemis git commit: ActiveMQRAStreamMessage writeBytes(..) should trace array contents

Posted by cl...@apache.org.
ActiveMQRAStreamMessage writeBytes(..) should trace array contents


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/8a09e8f0
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/8a09e8f0
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/8a09e8f0

Branch: refs/heads/master
Commit: 8a09e8f0b5bb0c2d01eadbb9b4d846d658c7a3b4
Parents: 31fd920
Author: Thiago Kronig <ca...@uolinc.com>
Authored: Fri May 8 20:35:55 2015 -0300
Committer: Clebert Suconic <cl...@apache.org>
Committed: Thu May 21 19:45:01 2015 -0400

----------------------------------------------------------------------
 .../org/apache/activemq/artemis/ra/ActiveMQRAStreamMessage.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/8a09e8f0/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRAStreamMessage.java
----------------------------------------------------------------------
diff --git a/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRAStreamMessage.java b/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRAStreamMessage.java
index 7e3d504..5c99b09 100644
--- a/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRAStreamMessage.java
+++ b/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRAStreamMessage.java
@@ -266,7 +266,7 @@ public class ActiveMQRAStreamMessage extends ActiveMQRAMessage implements Stream
    {
       if (ActiveMQRAStreamMessage.trace)
       {
-         ActiveMQRALogger.LOGGER.trace("writeBytes(" + value + ", " + offset + ", " + length + ")");
+         ActiveMQRALogger.LOGGER.trace("writeBytes(" + Arrays.toString(value) + ", " + offset + ", " + length + ")");
       }
 
       ((StreamMessage)message).writeBytes(value, offset, length);
@@ -281,7 +281,7 @@ public class ActiveMQRAStreamMessage extends ActiveMQRAMessage implements Stream
    {
       if (ActiveMQRAStreamMessage.trace)
       {
-         ActiveMQRALogger.LOGGER.trace("writeBytes(" + value + ")");
+         ActiveMQRALogger.LOGGER.trace("writeBytes(" + Arrays.toString(value) + ")");
       }
 
       ((StreamMessage)message).writeBytes(value);


[10/10] activemq-artemis git commit: This closes #236

Posted by cl...@apache.org.
This closes #236


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/30416db0
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/30416db0
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/30416db0

Branch: refs/heads/master
Commit: 30416db00e65ef3e238240c32d70dcecb47ecfde
Parents: 27cbc92 7ca0575
Author: Clebert Suconic <cl...@apache.org>
Authored: Thu May 21 19:45:02 2015 -0400
Committer: Clebert Suconic <cl...@apache.org>
Committed: Thu May 21 19:45:02 2015 -0400

----------------------------------------------------------------------
 .../artemis/jms/bridge/impl/JMSBridgeImpl.java      |  1 +
 .../jms/server/config/JMSQueueConfiguration.java    |  2 +-
 .../artemis/ra/ActiveMQRAStreamMessage.java         |  4 ++--
 .../artemis/core/server/impl/QueueImpl.java         |  4 +++-
 pom.xml                                             | 16 ++++++++++++++++
 .../tests/integration/client/LargeMessageTest.java  |  3 ++-
 .../cluster/distribution/ClusterTestBase.java       |  4 ++--
 .../tests/integration/discovery/DiscoveryTest.java  |  2 +-
 .../management/ManagementHelperTest.java            |  5 +++--
 .../apache/activemq/artemis/jms/ActiveMQAdmin.java  |  1 -
 10 files changed, 31 insertions(+), 11 deletions(-)
----------------------------------------------------------------------



[07/10] activemq-artemis git commit: Remove ignored line in JoramTests

Posted by cl...@apache.org.
Remove ignored line in JoramTests


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/71ea52bd
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/71ea52bd
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/71ea52bd

Branch: refs/heads/master
Commit: 71ea52bd060a9ec9eb203f49e62438c524e70345
Parents: 8a09e8f
Author: Thiago Kronig <ca...@uolinc.com>
Authored: Fri May 8 20:41:28 2015 -0300
Committer: Clebert Suconic <cl...@apache.org>
Committed: Thu May 21 19:45:01 2015 -0400

----------------------------------------------------------------------
 .../test/java/org/apache/activemq/artemis/jms/ActiveMQAdmin.java    | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/71ea52bd/tests/joram-tests/src/test/java/org/apache/activemq/artemis/jms/ActiveMQAdmin.java
----------------------------------------------------------------------
diff --git a/tests/joram-tests/src/test/java/org/apache/activemq/artemis/jms/ActiveMQAdmin.java b/tests/joram-tests/src/test/java/org/apache/activemq/artemis/jms/ActiveMQAdmin.java
index c99cc55..68c6333 100644
--- a/tests/joram-tests/src/test/java/org/apache/activemq/artemis/jms/ActiveMQAdmin.java
+++ b/tests/joram-tests/src/test/java/org/apache/activemq/artemis/jms/ActiveMQAdmin.java
@@ -252,7 +252,6 @@ public class ActiveMQAdmin implements Admin
       while ((line = br.readLine()) != null)
       {
          System.out.println("SERVER: " + line);
-         line.replace('|', '\n');
          if ("OK".equals(line.trim()))
          {
             new Thread()


[08/10] activemq-artemis git commit: Explicit byte[].toString(..) in debug message

Posted by cl...@apache.org.
Explicit byte[].toString(..) in debug message


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/b6093579
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/b6093579
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/b6093579

Branch: refs/heads/master
Commit: b6093579bfd06810a510e63fed3c27a80112184b
Parents: d99991d
Author: Thiago Kronig <ca...@uolinc.com>
Authored: Fri May 8 20:12:15 2015 -0300
Committer: Clebert Suconic <cl...@apache.org>
Committed: Thu May 21 19:45:01 2015 -0400

----------------------------------------------------------------------
 .../org/apache/activemq/artemis/core/server/impl/QueueImpl.java  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/b6093579/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
index 226cf76..6e57af5 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
@@ -2465,6 +2465,7 @@ public class QueueImpl implements Queue
       acknowledge(tx, ref);
    }
 
+   @SuppressWarnings({"ArrayToString", "ArrayToStringConcatentation"})
    private void moveBetweenSnFQueues(final SimpleString queueSuffix,
                                      final Transaction tx,
                                      final MessageReference ref) throws Exception
@@ -2481,7 +2482,8 @@ public class QueueImpl implements Queue
          if (propName.startsWith(MessageImpl.HDR_ROUTE_TO_IDS))
          {
             oldRouteToIDs = (byte[]) copyMessage.removeProperty(propName);
-            ActiveMQServerLogger.LOGGER.debug("Removed property from message: " + propName + " = " + oldRouteToIDs + " (" + ByteBuffer.wrap(oldRouteToIDs).getLong() + ")");
+            final String hashcodeToString = oldRouteToIDs.toString(); // don't use Arrays.toString(..) here
+            ActiveMQServerLogger.LOGGER.debug("Removed property from message: " + propName + " = " + hashcodeToString + " (" + ByteBuffer.wrap(oldRouteToIDs).getLong() + ")");
 
             // there should only be one of these properties so potentially save some loop iterations
             break;


[03/10] activemq-artemis git commit: Document lock.wait(..) idiom in SourceReceiver Thread

Posted by cl...@apache.org.
Document lock.wait(..) idiom in SourceReceiver Thread


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/bbc509c6
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/bbc509c6
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/bbc509c6

Branch: refs/heads/master
Commit: bbc509c654a1ef711fa1e93ebaa67b6a81f5874d
Parents: b609357
Author: Thiago Kronig <ca...@uolinc.com>
Authored: Fri May 8 20:22:29 2015 -0300
Committer: Clebert Suconic <cl...@apache.org>
Committed: Thu May 21 19:45:01 2015 -0400

----------------------------------------------------------------------
 .../org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java  | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bbc509c6/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java
----------------------------------------------------------------------
diff --git a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java
index c8d7e13..5881e0d 100644
--- a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java
+++ b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java
@@ -1878,6 +1878,7 @@ public final class JMSBridgeImpl implements JMSBridge
       }
 
       @Override
+      @SuppressWarnings("WaitNotInLoop") // both lock.wait(..) either returns, throws or continue, thus avoiding spurious wakes
       public void run()
       {
          while (started)


[02/10] activemq-artemis git commit: Log Arrays.toString(nodes) at ClusterTestBase

Posted by cl...@apache.org.
Log Arrays.toString(nodes) at ClusterTestBase


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/27dd5c26
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/27dd5c26
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/27dd5c26

Branch: refs/heads/master
Commit: 27dd5c2652b70584e87f915848caa733582baaa7
Parents: 71ea52b
Author: Thiago Kronig <ca...@uolinc.com>
Authored: Fri May 8 20:53:11 2015 -0300
Committer: Clebert Suconic <cl...@apache.org>
Committed: Thu May 21 19:45:01 2015 -0400

----------------------------------------------------------------------
 .../tests/integration/cluster/distribution/ClusterTestBase.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/27dd5c26/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusterTestBase.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusterTestBase.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusterTestBase.java
index 16ce2bc..e3e63db 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusterTestBase.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusterTestBase.java
@@ -276,7 +276,7 @@ public abstract class ClusterTestBase extends ServiceTestBase
    {
       ActiveMQServer server = servers[bNode];
 
-      log.debug("waiting for " + nodes + " on the topology for server = " + server);
+      log.debug("waiting for " + Arrays.toString(nodes) + " on the topology for server = " + server);
 
       long start = System.currentTimeMillis();
 
@@ -322,7 +322,7 @@ public abstract class ClusterTestBase extends ServiceTestBase
          while (System.currentTimeMillis() - start < WAIT_TIMEOUT);
          if (!exists)
          {
-            String msg = "Timed out waiting for cluster topology of " + nodes +
+            String msg = "Timed out waiting for cluster topology of " + Arrays.toString(nodes) +
                " (received " +
                topology.getMembers().size() +
                ") topology = " +


[04/10] activemq-artemis git commit: Enable Google's Error Prone

Posted by cl...@apache.org.
Enable Google's Error Prone

Enabled by default to catch common Java mistakes as compile-time errors.

https://github.com/google/error-prone


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/592f28f0
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/592f28f0
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/592f28f0

Branch: refs/heads/master
Commit: 592f28f03f8f6eebafaf288468c032beca31a032
Parents: 27cbc92
Author: Thiago Kronig <ca...@uolinc.com>
Authored: Tue May 5 14:23:40 2015 -0300
Committer: Clebert Suconic <cl...@apache.org>
Committed: Thu May 21 19:45:01 2015 -0400

----------------------------------------------------------------------
 pom.xml | 12 ++++++++++++
 1 file changed, 12 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/592f28f0/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 61824fd..af558b1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -700,6 +700,18 @@
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-compiler-plugin</artifactId>
                <version>3.1</version>
+               <!-- Enable Google's Error-Prone https://github.com/google/error-prone -->
+               <configuration>
+                 <compilerId>javac-with-errorprone</compilerId>
+                 <forceJavacCompilerUse>true</forceJavacCompilerUse>
+               </configuration>
+               <dependencies>
+                 <dependency>
+                   <groupId>org.codehaus.plexus</groupId>
+                   <artifactId>plexus-compiler-javac-errorprone</artifactId>
+                   <version>2.5</version>
+                 </dependency>
+               </dependencies>
             </plugin>
             <plugin>
                <groupId>org.apache.maven.plugins</groupId>


[05/10] activemq-artemis git commit: Ignore DepAnn Error Prone ERROR as WARN

Posted by cl...@apache.org.
Ignore DepAnn Error Prone ERROR as WARN

DepAnn fail as ERROR for generated sources that implement deprecated methods,
but don't annotate with @Deprecated.

Also, see: http://errorprone.info/bugpattern/DepAnn


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/d99991dd
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/d99991dd
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/d99991dd

Branch: refs/heads/master
Commit: d99991dd3accb486cbbea926fcf1529670b4961b
Parents: 592f28f
Author: Thiago Kronig <ca...@uolinc.com>
Authored: Tue May 5 15:15:09 2015 -0300
Committer: Clebert Suconic <cl...@apache.org>
Committed: Thu May 21 19:45:01 2015 -0400

----------------------------------------------------------------------
 pom.xml | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/d99991dd/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index af558b1..103ddba 100644
--- a/pom.xml
+++ b/pom.xml
@@ -704,6 +704,10 @@
                <configuration>
                  <compilerId>javac-with-errorprone</compilerId>
                  <forceJavacCompilerUse>true</forceJavacCompilerUse>
+                 <compilerArgs>
+                   <!-- DepAnn fail for generated sources. Changing to WARN instead -->
+                   <arg>-Xep:DepAnn:WARN</arg>
+                 </compilerArgs>
                </configuration>
                <dependencies>
                  <dependency>


[06/10] activemq-artemis git commit: Fix JMSQueueConfiguration interface to use varargs instead of array[]

Posted by cl...@apache.org.
Fix JMSQueueConfiguration interface to use varargs instead of array[]


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/31fd920e
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/31fd920e
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/31fd920e

Branch: refs/heads/master
Commit: 31fd920e952fa813ce0ce4415985bf2bac32ee4b
Parents: bbc509c
Author: Thiago Kronig <ca...@uolinc.com>
Authored: Fri May 8 20:31:51 2015 -0300
Committer: Clebert Suconic <cl...@apache.org>
Committed: Thu May 21 19:45:01 2015 -0400

----------------------------------------------------------------------
 .../activemq/artemis/jms/server/config/JMSQueueConfiguration.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/31fd920e/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/JMSQueueConfiguration.java
----------------------------------------------------------------------
diff --git a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/JMSQueueConfiguration.java b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/JMSQueueConfiguration.java
index f84b8d3..1c6e84b 100644
--- a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/JMSQueueConfiguration.java
+++ b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/JMSQueueConfiguration.java
@@ -32,5 +32,5 @@ public interface JMSQueueConfiguration
 
    String[] getBindings();
 
-   JMSQueueConfiguration setBindings(String[] bindings);
+   JMSQueueConfiguration setBindings(String... bindings);
 }