You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "xtern (via GitHub)" <gi...@apache.org> on 2024/04/01 15:51:49 UTC
[PR] IGNITE-21094 [ignite-3]
xtern opened a new pull request, #3536:
URL: https://github.com/apache/ignite-3/pull/3536
https://issues.apache.org/jira/browse/IGNITE-21094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21094 Sql. Combine single/script query execution methods into a single one. [ignite-3]
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #3536:
URL: https://github.com/apache/ignite-3/pull/3536#discussion_r1547527706
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/Commons.java:
##########
@@ -896,4 +899,11 @@ public static List<RelNode> castInputsToLeastRestrictiveTypeIfNeeded(List<RelNod
return actualInputs;
}
+
+ /** Returns {@code true} if the specified properties allow multi-statement query execution. */
+ public static boolean isMultiStatementQuery(SqlProperties properties) {
Review Comment:
maybe it is better to rename it to reflect the real purpose of the method, e.g. `isMultiStatementQueryAllow'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21094 Sql. Combine single/script query execution methods into a single one. [ignite-3]
Posted by "xtern (via GitHub)" <gi...@apache.org>.
xtern merged PR #3536:
URL: https://github.com/apache/ignite-3/pull/3536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org